Skip to content

Add orthotope, dependent-enummap and ox-arrays - #7799

Merged
mihaimaruseac merged 1 commit into
commercialhaskell:masterfrom
Mikolaj:master
Aug 27, 2025
Merged

Add orthotope, dependent-enummap and ox-arrays#7799
mihaimaruseac merged 1 commit into
commercialhaskell:masterfrom
Mikolaj:master

Conversation

@Mikolaj

@Mikolaj Mikolaj commented Jul 19, 2025

Copy link
Copy Markdown
Contributor

Checklist:

  • Meaningful commit message, eg add my-cool-package (please don't mention build-constraints.yml)
  • At least 30 minutes have passed since uploading to Hackage
  • If applicable, required system libraries are added to 02-apt-get-install.sh or 03-custom-install.sh
  • (recommended) Package have been verified to work with the latest nightly snapshot, e.g by running the verify-package script
  • (optional) Package is compatible with the latest version of all dependencies (Run cabal update && cabal outdated)

The script runs virtually the following commands in a clean directory:

  stack unpack $package-$version # `-$version` is optional
  cd $package-$version
  rm -f stack.yaml && stack init --resolver nightly --ignore-subdirs
  stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

@Mikolaj
Mikolaj marked this pull request as draft July 19, 2025 09:43
@juhp

juhp commented Jul 20, 2025

Copy link
Copy Markdown
Member

Hmm this may not be easy: ilist was last in nightly end of Dec, orthoscope could be doable if it can accept latest QuickCheck. Or you could just start with dependent-enummap?

@Mikolaj

Mikolaj commented Jul 20, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for the tip about orthotope, @juhp. I've already replaced ilist and I'm working on the rest. May take a while.

juhp added a commit that referenced this pull request Jul 20, 2025
@Mikolaj
Mikolaj force-pushed the master branch 2 times, most recently from dda69d4 to ed162fb Compare July 27, 2025 00:15
@Mikolaj Mikolaj changed the title Add dependent-enummap, ox-arrays and horde-ad Add orthotope, dependent-enummap and ox-arrays Jul 27, 2025
@juhp

juhp commented Jul 30, 2025

Copy link
Copy Markdown
Member

It may be quicker for you to test locally: stack --resolver nightly build orthotope ox-arrays
but yeah it is not going to build without that revision for QuickCheck I mentioned.

@Mikolaj

Mikolaj commented Jul 30, 2025

Copy link
Copy Markdown
Contributor Author

It may be quicker for you to test locally: stack --resolver nightly build orthotope ox-arrays but yeah it is not going to build without that revision for QuickCheck I mentioned.

Yes, you were right. I notified the maintainer and the revision is already done in the repo, but Hackage needs to be revised.

BTW, I gave up adding horde-ad for now, because it needs GHC 9.12.3 (it triggers a 9.12-only GHC bug) and nightly now uses 9.12 as opposed to 9.10.

@juhp

juhp commented Aug 26, 2025

Copy link
Copy Markdown
Member

We need to enable orthotope now.

@mihaimaruseac
mihaimaruseac merged commit 9e2296e into commercialhaskell:master Aug 27, 2025
0 of 2 checks passed
@Mikolaj

Mikolaj commented Aug 28, 2025

Copy link
Copy Markdown
Contributor Author

@juhp: thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants