Repository navigation
Commit 3f3da36
fix: count things checked, not rule evaluations
The header on this pull request read "1 of 100 checks failed". The number was
arithmetically right — sixteen commit messages against six enabled rules, plus
two branch rules and one each for author name and email — but it was the wrong
number to show.
It measured the size of the pull request rather than the strictness of the
policy: the same configuration reports 100 on a fifteen-commit branch and 10 on
a one-commit branch. Ninety-six of the hundred were the same six rules run
again per commit, so the total also overstated the work done. Worst of all, the
inflated denominator made a real failure look negligible: one bad commit out of
fifteen is not "1 of 100".
A check is now one thing that was checked — a commit message, the branch, the
author — so the same report reads "1 of 19 checks failed", and the total is
what the reader can count in the details block. Rule-level detail is unchanged;
it lives in the table and the details, which is where someone goes to find out
what to fix.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn1 parent 56e6f50 commit 3f3da36
2 files changed
Lines changed: 52 additions & 33 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
403 | 403 | | |
404 | 404 | | |
405 | 405 | | |
406 | | - | |
407 | | - | |
408 | | - | |
409 | | - | |
410 | | - | |
411 | | - | |
412 | | - | |
413 | | - | |
414 | | - | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
415 | 420 | | |
416 | | - | |
417 | | - | |
418 | | - | |
419 | | - | |
420 | | - | |
421 | | - | |
422 | | - | |
423 | | - | |
424 | | - | |
| 421 | + | |
| 422 | + | |
425 | 423 | | |
426 | 424 | | |
427 | 425 | | |
428 | | - | |
| 426 | + | |
429 | 427 | | |
430 | 428 | | |
431 | 429 | | |
| |||
528 | 526 | | |
529 | 527 | | |
530 | 528 | | |
531 | | - | |
| 529 | + | |
532 | 530 | | |
533 | 531 | | |
534 | | - | |
| 532 | + | |
535 | 533 | | |
536 | 534 | | |
537 | 535 | | |
| |||
553 | 551 | | |
554 | 552 | | |
555 | 553 | | |
556 | | - | |
| 554 | + | |
557 | 555 | | |
558 | 556 | | |
559 | 557 | | |
560 | 558 | | |
561 | 559 | | |
562 | 560 | | |
563 | | - | |
| 561 | + | |
564 | 562 | | |
565 | 563 | | |
566 | 564 | | |
| |||
577 | 575 | | |
578 | 576 | | |
579 | 577 | | |
580 | | - | |
581 | | - | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
582 | 582 | | |
583 | 583 | | |
584 | 584 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
711 | 711 | | |
712 | 712 | | |
713 | 713 | | |
714 | | - | |
715 | | - | |
716 | | - | |
717 | | - | |
718 | | - | |
719 | | - | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
720 | 722 | | |
721 | 723 | | |
722 | 724 | | |
| |||
726 | 728 | | |
727 | 729 | | |
728 | 730 | | |
729 | | - | |
730 | | - | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
731 | 750 | | |
732 | 751 | | |
733 | 752 | | |
| |||
0 commit comments