Repository navigation
Commit eee7e73
fix: drop the header logo, which read as a second status signal
Raised by @shenxianpeng looking at a failing report: is this thing telling
me it passed or failed?
The org mark is a white check inside a rounded tile. GitHub's ✅ is a white
check inside a rounded square. Same shape, same silhouette, differing only in
hue -- and hue is the weakest channel to carry meaning at 24px. So a failing
report opened with a tick and then said "❌ 2 of 4 checks failed": the first
symbol the eye lands on contradicted the second, and it did so exactly when
the reader most needs to take the result in at a glance.
Success was fine, both symbols agreeing. That is what hid it: the ambiguity
only appears on failure, which is the case that matters most and the one you
see least while building the thing.
Three changes walked it here, each locally reasonable. The original wordmark
badge carried "COMMIT" in it, so it read as a logo. #259 replaced it with the
new wordless mark, which was faint but still decoration. #261 filled it in to
give it presence -- and a filled tile with a check in it is not decoration, it
is a status chip. Adding visual weight added semantic weight with it.
So the header is now plain "## Commit Check". The verdict line is the single
status signal, which is the right number of them; the words carry the brand
without claiming an outcome.
assets/logo.png stays. It is unreferenced by this repo now, but the raw URL
is public and may be linked from outside, and 2.8 KB is cheaper than a broken
image somewhere I cannot see.
Comment identity is unaffected: comments are matched on COMMENT_MARKER, an
invisible HTML comment, not on the title, so existing comments are still
adopted and edited in place rather than duplicated.
The golden tests build their expected header from main.REPORT_TITLE, so they
followed the change without edits; 99 pass.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn1 parent c6dd962 commit eee7e73
2 files changed
Lines changed: 19 additions & 23 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
245 | | - | |
| 245 | + | |
246 | 246 | | |
247 | 247 | | |
248 | 248 | | |
| |||
266 | 266 | | |
267 | 267 | | |
268 | 268 | | |
269 | | - | |
| 269 | + | |
270 | 270 | | |
271 | 271 | | |
272 | 272 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | 32 | | |
51 | 33 | | |
52 | | - | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
53 | 49 | | |
54 | 50 | | |
55 | 51 | | |
| |||
574 | 570 | | |
575 | 571 | | |
576 | 572 | | |
577 | | - | |
| 573 | + | |
578 | 574 | | |
579 | 575 | | |
580 | 576 | | |
| |||
599 | 595 | | |
600 | 596 | | |
601 | 597 | | |
602 | | - | |
| 598 | + | |
603 | 599 | | |
604 | 600 | | |
605 | 601 | | |
| |||
0 commit comments