Repository navigation
fix: show an AI-only check that ran no rule as skipped, and group the PR title with the description - #330
Conversation
… PR title with the description Under the default ai_attribution = "ignore" the PR description check ran no rule but showed a pass. The title and description now share a Pull request group, so the commit group is no longer split in two.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Commit Check✅ All 7 checks passed Show all 7 checkscommit-check 2.20.2 · Rules reference |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 791 799 +8
=========================================
+ Hits 791 799 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What
Two output fixes:
ai_attribution = "ignore"the CLI runs none of the AI rules, returns an empty list of checks, and the Action showed a pass. Someone who turned onpr-body-ai-attributionand forgot the policy saw ✔ and thought descriptions were being checked.Before vs after
Step log on a pull request with
pr-title,pr-body-ai-attributionandmessageon, noai_attributionin the config:Before:
After:
A rule that did run keeps its verdict, and unparsable CLI output still fails.
Second commit (drop it if you prefer)
ci: forbid AI attribution in this repoaddsai_attribution = "forbid"to this repo'scommit-check.toml, so the self-test checks the PR description for real. The org config's[commit]keys are still inherited (checked: CC001 still fails a non-conventional message). The last 40 commits onmainpass it. A PR opened with an AI footer in its description will now fail until the footer is removed.Tests
New tests for the skip and the grouping; five golden outputs updated for the new group. 284 tests pass;
main.pystays at 100% line and branch coverage. README samples updated.Summary by CodeRabbit
New Features
Improvements