Repository navigation
fix: check the author of every pull request commit - #332
Merged
Merged
Conversation
author-name and author-email read only the branch tip, so an earlier commit by another author went unchecked: a GitHub noreply address forbidden by author_email_pattern passed when the last commit used a real one. Each distinct author of the pull request's commits is now checked once, on the newest commit that carries it. When a commit cannot be had, even by fetching it, the tip is checked as before.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
Commit Check✅ All 8 checks passed Show all 8 checkscommit-check 2.20.2 · Rules reference |
shenxianpeng
removed
the
ai-assisted
Claude
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 822 842 +20
=========================================
+ Hits 822 842 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…mmit-author # Conflicts: # main.py # main_test.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
author-nameandauthor-emailchecked only the pull request's last commit. An earlier commit by another author was never checked, so a GitHub noreply address forbidden byauthor_email_pattern(the setup from commit-check#651) passed whenever the last commit used a real address.Now each distinct author of the pull request's commits is checked once, on the newest commit that carries it, with
--rev <sha>. A one-person pull request still gets one scope per check. A commit the clone lacks is fetched without its history; if one still cannot be had, the tip is checked as before.Before / after
A pull request with two commits: the first by
dev@users.noreply.github.com, the second bydev@example.org, and the noreply-forbiddingauthor_email_pattern:Tests
pytest main_test.py: 288 passed. New tests: an earlier commit by another author is checked, one author is checked once on the newest commit, an API-listed author is used, and a commit that cannot be fetched falls back to the tip. The before/after above is a local run ofmain.pyagainst a real repository with apull_requestevent payload.