Repository navigation
Fix 500 on GET /_/contexts/<ShortName> - #583
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #583 +/- ##
=========================================
Coverage 97.09% 97.09%
- Complexity 5341 5342 +1
=========================================
Files 438 438
Lines 13817 13821 +4
=========================================
+ Hits 13415 13419 +4
Misses 402 402
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #582
API Platform's
ContextActionstores an array as the request'sdatawith noresource_class, soPublishableEventListener::onPostRespond()calledisConfigured(null)and the request failed with a TypeError. The listener now returns early when there is no resource class.Publishable\PublishableJsonLdContextTestrequests/contexts/DummyPublishableComponentand/contexts/Pageanonymously and as an admin, expecting 200 (failed with the TypeError before the fix).EventListener\Api\PublishableEventListenerTestcovers array data with no resource class, so Infection's unit-only gate covers the changed line.🤖 Generated with Claude Code