fix: isolate install and uninstall entrypoints

Author: onjsdnjs

README.md

@@ -33,7 +33,7 @@ $ErrorActionPreference='Stop'; & ([scriptblock]::Create((Invoke-WebRequest https
 
 - 변경되지 않는 버전별 설치기: `https://install.ctxa.ai/<installer-tag>/install.sh` 또는 `install.ps1`
 - 고정 CLI 릴리스 설치: `CONTEXA_VERSION=<release-tag>`
-- 직전 정상 바이너리로 롤백: `CONTEXA_INSTALL_ACTION=rollback`
+- 직전 정상 바이너리로 롤백: 내려받은 설치 파일을 `install.ps1 -Action rollback` 또는 `install.sh rollback`으로 실행
 - Windows CLI 바이너리 제거: `irm https://install.ctxa.ai/uninstall.ps1 | iex`
 - Linux/macOS CLI 바이너리 제거: `curl -fsSL https://install.ctxa.ai/uninstall.sh | sh`
 - 사용자 프로젝트 원복: `contexa reset` — CLI 제거와 다른 작업입니다.

install.ps1

@@ -1,6 +1,9 @@
 #Requires -Version 5.1
 
+param([string]$Action = 'install')
+
 & {
+$RequestedAction = if ([string]::IsNullOrWhiteSpace($Action)) { 'install' } else { $Action.Trim().ToLowerInvariant() }
 $DirectFileInvocation = -not [string]::IsNullOrWhiteSpace($PSCommandPath)
 $InstallerFailed = $false
 $ErrorActionPreference = 'Stop'
@@ -519,14 +522,14 @@ function Invoke-ContexaInstaller {
     $finalPath = Join-Path $installDir 'contexa.exe'
     $backupPath = $finalPath + '.previous'
     $markerPath = $finalPath + '.install-transaction.json'
-    $action = if ([string]::IsNullOrWhiteSpace($env:CONTEXA_INSTALL_ACTION)) { 'install' } else { $env:CONTEXA_INSTALL_ACTION.Trim().ToLowerInvariant() }
+    $action = $RequestedAction
 
     if (-not (Test-Path -LiteralPath $installDir)) { New-Item -ItemType Directory -Path $installDir -Force | Out-Null }
     Invoke-InstallerTransactionRecovery $installDir $finalPath $backupPath $markerPath
     if ($action -eq 'rollback') { Invoke-Rollback $finalPath $backupPath; Ensure-CommandPath $installDir $finalPath; return }
     if ($action -eq 'uninstall') { Invoke-Uninstall $installDir $finalPath $backupPath; return }
     if ($action -ne 'install') {
-        throw ((Select-InstallerText 'Unsupported CONTEXA_INSTALL_ACTION' '7KeA7JuQ7ZWY7KeAIOyViuuKlCBDT05URVhBX0lOU1RBTExfQUNUSU9O') + ': ' + $action)
+        throw ((Select-InstallerText 'Unsupported installer action' '7KeA7JuQ7ZWY7KeAIOyViuuKlCDshKTsuZgg7J6R7JeF') + ': ' + $action)
     }
 
     Write-Host ('  ' + (Select-InstallerText 'Starting Contexa CLI installation.' 'Q29udGV4YSBDTEkg7ISk7LmY66W8IOyLnOyeke2VqeuLiOuLpC4='))
@@ -641,7 +644,7 @@ function Invoke-ContexaInstaller {
         Write-Host '    contexa init --simulate'
         Write-Host '    contexa reset --simulate'
         Write-Host ('  ' + (Select-InstallerText 'Immutable reinstall: set CONTEXA_VERSION=' '64+Z7J28IOuyhOyghCDsnqzshKTsuZg6IENPTlRFWEFfVkVSU0lPTj0=') + $version + (Select-InstallerText ' and run this installer again.' '7J2EIOyEpOygle2VmOqzoCDshKTsuZgg7ZSE66Gc6re4656o7J2EIOuLpOyLnCDsi6TtlontlZjshLjsmpQu'))
-        Write-Host ('  ' + (Select-InstallerText 'Rollback: set CONTEXA_INSTALL_ACTION=rollback and run this installer.' '66Gk67CxOiBDT05URVhBX0lOU1RBTExfQUNUSU9OPXJvbGxiYWNr7J2EIOyEpOygle2VmOqzoCDshKTsuZgg7ZSE66Gc6re4656o7J2EIOyLpO2Wie2VmOyEuOyalC4='))
+        Write-Host ('  ' + (Select-InstallerText 'Rollback: run the downloaded install.ps1 file with -Action rollback.' '66Gk67CxOiBpbnN0YWxsLnBzMSDtjIzsnbzsnYQgLUFjdGlvbiByb2xsYmFjayDsmLXshZjsnLzroZwg7Iuk7ZaJ7ZWY7Iut7Iuc7JikLg=='))
         Write-Host ('  ' + (Select-InstallerText 'Uninstall: irm https://install.ctxa.ai/uninstall.ps1 | iex (project reset is separate).' '7KCc6rGwOiBpcm0gaHR0cHM6Ly9pbnN0YWxsLmN0eGEuYWkvdW5pbnN0YWxsLnBzMSB8IGlleCAo7ZSE66Gc7KCd7Yq4IHJlc2V07J2AIOuzhOuPhCk='))
     } catch {
         if ($oldMoved -and -not (Test-Path -LiteralPath $finalPath) -and (Test-Path -LiteralPath $backupPath)) {

install.sh

@@ -23,9 +23,9 @@ msg() {
       installed) printf '%s' ' 설치와 검증을 완료했습니다: ' ;;
       primary) printf '%s' '주요 명령:' ;;
       immutable) printf '%s' '동일 버전 재설치: CONTEXA_VERSION=' ;;
-      rollback) printf '%s' '롤백: CONTEXA_INSTALL_ACTION=rollback' ;;
+      rollback) printf '%s' '롤백: install.sh rollback' ;;
       uninstall) printf '%s' '제거: curl -fsSL https://install.ctxa.ai/uninstall.sh | sh (프로젝트 reset은 별도)' ;;
-      unsupported_action) printf '%s' '지원하지 않는 CONTEXA_INSTALL_ACTION' ;;
+      unsupported_action) printf '%s' '지원하지 않는 설치 작업' ;;
     esac
   else
     case "$key" in
@@ -37,9 +37,9 @@ msg() {
       installed) printf '%s' ' installed and verified for ' ;;
       primary) printf '%s' 'Primary commands:' ;;
       immutable) printf '%s' 'Immutable reinstall: CONTEXA_VERSION=' ;;
-      rollback) printf '%s' 'Rollback: CONTEXA_INSTALL_ACTION=rollback' ;;
+      rollback) printf '%s' 'Rollback: install.sh rollback' ;;
       uninstall) printf '%s' 'Uninstall: curl -fsSL https://install.ctxa.ai/uninstall.sh | sh (project reset is separate)' ;;
-      unsupported_action) printf '%s' 'Unsupported CONTEXA_INSTALL_ACTION' ;;
+      unsupported_action) printf '%s' 'Unsupported installer action' ;;
     esac
   fi
 }
@@ -416,7 +416,7 @@ INSTALL_DIR=$(cd "$INSTALL_DIR" && pwd -P)
 INSTALL_PATH="$INSTALL_DIR/contexa"
 BACKUP_PATH="$INSTALL_PATH.previous"
 MARKER_PATH="$INSTALL_PATH.install-transaction"
-ACTION="${CONTEXA_INSTALL_ACTION:-install}"
+ACTION="${1:-install}"
 
 recover_installer_transaction
 case "$ACTION" in

test/installer-runtime.test.js

@@ -222,8 +222,12 @@ function windowsChannelInstallerEnv(base, installDir, keyXml) {
 }
 
 function runWindowsInstaller(env, timeout = 10000) {
+  const action = env.CONTEXA_INSTALL_ACTION || 'install';
+  const runtimeEnv = { ...env };
+  delete runtimeEnv.CONTEXA_INSTALL_ACTION;
   return run(powershell,
-    ['-NoProfile', '-NonInteractive', '-ExecutionPolicy', 'Bypass', '-File', ps1], env, timeout);
+    ['-NoProfile', '-NonInteractive', '-ExecutionPolicy', 'Bypass', '-File', ps1, '-Action', action],
+    runtimeEnv, timeout);
 }
 
 function runWindowsInstallerViaIex(env, timeout = 10000, catchFailure = false) {
@@ -236,7 +240,12 @@ function runWindowsInstallerViaIex(env, timeout = 10000, catchFailure = false) {
     ['-NoProfile', '-NonInteractive', '-ExecutionPolicy', 'Bypass', '-Command', command], env, timeout);
 }
 function runPwshInstaller(env) {
-  return run(pwsh, ['-NoProfile', '-NonInteractive', '-ExecutionPolicy', 'Bypass', '-File', ps1], env);
+  const action = env.CONTEXA_INSTALL_ACTION || 'install';
+  const runtimeEnv = { ...env };
+  delete runtimeEnv.CONTEXA_INSTALL_ACTION;
+  return run(pwsh,
+    ['-NoProfile', '-NonInteractive', '-ExecutionPolicy', 'Bypass', '-File', ps1, '-Action', action],
+    runtimeEnv);
 }
 
 function toPosixPath(value) {
@@ -281,10 +290,19 @@ function posixInstallerEnv(base, harness, publicKeyPath, version = '') {
   };
 }
 
-function runPosixInstaller(env, installer = sh) {
+function runPosixInstaller(env, installer = sh, explicitAction = undefined) {
   const quotedPath = env.PATH.replace(/'/g, `'"'"'`);
   const scriptPath = toPosixPath(installer).replace(/'/g, `'"'"'`);
-  return run(gitSh, ['-c', `PATH='${quotedPath}'; export PATH; exec '${scriptPath}'`], env);
+  const runtimeEnv = { ...env };
+  let action = '';
+  if (explicitAction === null) {
+    // Keep a leaked legacy environment value to prove the public install entrypoint ignores it.
+  } else {
+    action = explicitAction === undefined ? (env.CONTEXA_INSTALL_ACTION || '') : explicitAction;
+    delete runtimeEnv.CONTEXA_INSTALL_ACTION;
+  }
+  const actionArgument = action ? ` '${String(action).replace(/'/g, `'"'"'`)}'` : '';
+  return run(gitSh, ['-c', `PATH='${quotedPath}'; export PATH; exec '${scriptPath}'${actionArgument}`], runtimeEnv);
 }
 
 function buildPosixCli(version, options = {}) {
@@ -402,7 +420,8 @@ test('PowerShell installer performs install, no-op, update, rollback and uninsta
   await withServer(releaseHandler(files), async (base) => {
     for (let iteration = 1; iteration <= lifecycleRepeats; iteration += 1) {
       const installDir = path.join(temp, `설치 경로 with space ${iteration}`);
-      const first = await runWindowsInstallerViaIex(windowsInstallerEnv(base, installDir, '9.9.1-test', xml));
+      const leakedActionEnv = windowsInstallerEnv(base, installDir, '9.9.1-test', xml, 'uninstall');
+      const first = await runWindowsInstallerViaIex(leakedActionEnv);
       assert.match(first.stdout, /__SHELL_ALIVE__/);
       assert.equal(first.code, 0, first.stderr || first.stdout);
       assert.match(first.stdout, /Starting Contexa CLI installation/);
@@ -990,7 +1009,11 @@ test('POSIX installer performs lifecycle and preserves the existing binary for t
   await withServer(releaseHandler(lifecycleFiles), async (base) => {
     for (let iteration = 1; iteration <= lifecycleRepeats; iteration += 1) {
       const lifecycleHarness = createPosixHarness(path.join(temp, `설치 경로 with space ${iteration}`));
-      const first = await runPosixInstaller(posixInstallerEnv(base, lifecycleHarness, publicKeyPath, currentVersion));
+      const leakedActionEnv = {
+        ...posixInstallerEnv(base, lifecycleHarness, publicKeyPath, currentVersion),
+        CONTEXA_INSTALL_ACTION: 'uninstall',
+      };
+      const first = await runPosixInstaller(leakedActionEnv, sh, null);
       assert.equal(first.code, 0, first.stderr || first.stdout);
       const installed = path.join(lifecycleHarness.installDir, 'contexa');
       assert.equal(spawnSync(gitSh, [toPosixPath(installed), '--version'], { encoding: 'utf8' }).stdout.trim(), currentVersion);
@@ -1215,18 +1238,12 @@ test('POSIX installer emits intact Korean success and error messages', { timeout
     CONTEXA_INSTALL_DIR: path.join(temp, 'bin'),
     CONTEXA_SKIP_PATH_UPDATE: '1',
   };
-  const uninstall = await run(gitSh, [scriptPath], {
-    ...baseEnv,
-    CONTEXA_INSTALL_ACTION: 'uninstall',
-  });
+  const uninstall = await run(gitSh, [scriptPath, 'uninstall'], baseEnv);
   assert.equal(uninstall.code, 0, uninstall.stderr || uninstall.stdout);
   assert.match(uninstall.stdout, /바이너리.*제거/);
   assert.equal((uninstall.stdout + uninstall.stderr).includes('\uFFFD'), false);
 
-  const invalid = await run(gitSh, [scriptPath], {
-    ...baseEnv,
-    CONTEXA_INSTALL_ACTION: 'invalid',
-  });
+  const invalid = await run(gitSh, [scriptPath, 'invalid'], baseEnv);
   assert.equal(invalid.code, 1);
   assert.match(invalid.stderr, /설치 프로그램 실패 \[INSTALLER_OPERATION_FAILED\].*오류 코드/s);
   assert.equal((invalid.stdout + invalid.stderr).includes('\uFFFD'), false);

test/installers.test.js

@@ -53,7 +53,7 @@ test('install.ps1 enforces the signed, bounded and atomic installation contract'
   assert.match(src, /\.new\.exe/);
   assert.match(src, /\[System\.IO\.File\]::Move\(\$temporaryPath, \$finalPath\)/);
   assert.match(src, /\.previous/);
-  assert.match(src, /CONTEXA_INSTALL_ACTION/);
+  assert.equal(src.includes('CONTEXA_INSTALL_ACTION'), false);
   assert.match(src, /CONTEXA_TRUSTED_PUBLIC_KEY_XML/);
   assert.match(src, /IsLoopback/);
   assert.match(src, /Test-BinarySmoke \$temporaryPath/);
@@ -93,7 +93,7 @@ test('install.sh enforces supported platforms, bounded download and atomic repla
   assert.match(src, /glibc 2\.28 or newer/);
   assert.match(src, /\.contexa\.new\.XXXXXX/);
   assert.match(src, /BACKUP_PATH="\$INSTALL_PATH\.previous"/);
-  assert.match(src, /CONTEXA_INSTALL_ACTION/);
+  assert.equal(src.includes('CONTEXA_INSTALL_ACTION'), false);
   assert.match(src, /CONTEXA_TRUSTED_PUBLIC_KEY_PATH/);
   assert.match(src, /loopback release server/);
   assert.match(src, /smoke_binary "\$NEW_BINARY"/);
@@ -127,11 +127,11 @@ test('public uninstall entrypoints reuse the installer without leaking control s
   const ps = read(uninstallPs1Path);
   const sh = read(uninstallShPath);
   assert.ok(ps.startsWith('#Requires -Version 5.1'));
-  assert.match(ps, /CONTEXA_INSTALL_ACTION = 'uninstall'/);
+  assert.match(ps, /-Action uninstall/);
   assert.match(ps, /https:\/\/install\.ctxa\.ai\/install\.ps1/);
-  assert.match(ps, /Remove-Item Env:CONTEXA_INSTALL_ACTION/);
+  assert.equal(ps.includes('CONTEXA_INSTALL_ACTION'), false);
   assert.ok(sh.startsWith('#!/bin/sh'));
-  assert.match(sh, /CONTEXA_INSTALL_ACTION=uninstall sh/);
+  assert.match(sh, /sh "\$installer_file" uninstall/);
   assert.match(sh, /https:\/\/install\.ctxa\.ai\/install\.sh/);
 });
 
@@ -181,11 +181,11 @@ test('api prioritizes explicit paths and exposes immutable version URLs', () =>
 
   const uninstallPs = invoke('/uninstall.ps1');
   assert.ok(uninstallPs.body.startsWith('#Requires -Version 5.1'));
-  assert.match(uninstallPs.body, /CONTEXA_INSTALL_ACTION = 'uninstall'/);
+  assert.match(uninstallPs.body, /-Action uninstall/);
 
   const uninstallSh = invoke('/uninstall.sh', 'WindowsPowerShell/5.1');
   assert.ok(uninstallSh.body.startsWith('#!/bin/sh'));
-  assert.match(uninstallSh.body, /CONTEXA_INSTALL_ACTION=uninstall sh/);
+  assert.match(uninstallSh.body, /sh "\$installer_file" uninstall/);
 
   const immutable = invoke('/v9.9.9-installer-test/install.ps1');
   assert.equal(immutable.statusCode, 302);
@@ -207,7 +207,7 @@ test('api prioritizes explicit paths and exposes immutable version URLs', () =>
     assert.equal(stable.headers['x-content-type-options'], 'nosniff');
     const stableUninstall = invoke('/uninstall.ps1');
     assert.equal(stableUninstall.statusCode, 200);
-    assert.match(stableUninstall.body, /CONTEXA_INSTALL_ACTION = 'uninstall'/);
+    assert.match(stableUninstall.body, /-Action uninstall/);
   } finally {
     if (originalStableRef === undefined) delete process.env.CONTEXA_STABLE_INSTALLER_REF;
     else process.env.CONTEXA_STABLE_INSTALLER_REF = originalStableRef;

uninstall.ps1

@@ -1,18 +1,6 @@
 #Requires -Version 5.1
 
 & {
-    $hadInstallAction = Test-Path Env:CONTEXA_INSTALL_ACTION
-    $previousInstallAction = $env:CONTEXA_INSTALL_ACTION
-
-    try {
-        $env:CONTEXA_INSTALL_ACTION = 'uninstall'
-        $installer = Invoke-WebRequest 'https://install.ctxa.ai/install.ps1' -UseBasicParsing
-        & ([scriptblock]::Create($installer.Content))
-    } finally {
-        if ($hadInstallAction) {
-            $env:CONTEXA_INSTALL_ACTION = $previousInstallAction
-        } else {
-            Remove-Item Env:CONTEXA_INSTALL_ACTION -ErrorAction SilentlyContinue
-        }
-    }
+    $installer = Invoke-WebRequest 'https://install.ctxa.ai/install.ps1' -UseBasicParsing
+    & ([scriptblock]::Create($installer.Content)) -Action uninstall
 }

uninstall.sh

@@ -9,4 +9,4 @@ if ! curl -fsSL --connect-timeout 5 --max-time 30 \
   exit 1
 fi
 
-CONTEXA_INSTALL_ACTION=uninstall sh "$installer_file"
+sh "$installer_file" uninstall