fix: accept stable starter release versions

Author: onjsdnjs

install.ps1

@@ -246,8 +246,8 @@ function Get-TargetRelease {
     if ($version -notmatch '^v[0-9A-Za-z][0-9A-Za-z._-]*$' -or $cliVersion -ne $version.Substring(1)) {
         throw 'Signed channel manifest tag and CLI version do not match.'
     }
-    if (-not $starterVersion.EndsWith('-SNAPSHOT')) {
-        throw 'Signed snapshot channel requires a SNAPSHOT starter version.'
+    if ($starterVersion -notmatch '^[0-9]+\.[0-9]+\.[0-9]+(?:-[0-9A-Za-z][0-9A-Za-z.-]*)?$') {
+        throw 'Signed channel manifest starter version is invalid.'
     }
     if ($releaseManifestSha256 -notmatch '^[0-9a-f]{64}$') {
         throw 'Signed channel manifest release digest is invalid.'

install.sh

@@ -496,7 +496,7 @@ else
   CHANNEL_RELEASE_MANIFEST_SHA=$(manifest_string_value "$CHANNEL_MANIFEST_FILE" releaseManifestSha256)
   [ "$RESOLVED_CHANNEL" = snapshot ] || fail "Signed channel manifest is not the snapshot channel."
   [ "$CHANNEL_CLI_VERSION" = "${VERSION#v}" ] || fail "Signed channel manifest tag and CLI version do not match."
-  case "$CHANNEL_STARTER_VERSION" in *-SNAPSHOT) ;; *) fail "Signed snapshot channel requires a SNAPSHOT starter version." ;; esac
+  printf '%s\n' "$CHANNEL_STARTER_VERSION" | grep -Eq '^[0-9]+\.[0-9]+\.[0-9]+(-[0-9A-Za-z][0-9A-Za-z.-]*)?$' || fail "Signed channel manifest starter version is invalid."
   printf '%s\n' "$CHANNEL_RELEASE_MANIFEST_SHA" | grep -Eq '^[0-9a-f]{64}$' || fail "Signed channel manifest release digest is invalid."
   printf '%s\n' "$CHANNEL_SOURCE_COMMIT" | grep -Eq '^[0-9a-f]{40}$' || fail "Signed channel manifest source commit is invalid."
 fi

test/installer-runtime.test.js

@@ -67,7 +67,7 @@ function createRelease(keys, version, platform, assetBytes, options = {}) {
     starter: {
       groupId: 'ai.ctxa',
       artifactId: 'spring-boot-starter-contexa',
-      version: options.releaseStarterVersion || '0.1.0-SNAPSHOT',
+      version: options.releaseStarterVersion || '0.1.0',
     },
     ...(options.omitSource ? {} : {
       source: {
@@ -100,7 +100,7 @@ function createChannel(keys, version, options = {}) {
     channel: options.channel || 'snapshot',
     releaseTag: options.releaseTag || `v${version}`,
     cliVersion: options.cliVersion || version,
-    starterVersion: options.starterVersion || '0.1.0-SNAPSHOT',
+    starterVersion: options.starterVersion || '0.1.0',
     sourceCommit: options.sourceCommit || 'a'.repeat(40),
     releaseManifestSha256: options.releaseManifestSha256 || '0'.repeat(64),
   }, null, 2)}\n`);
@@ -548,7 +548,8 @@ test('PowerShell installer resolves the signed snapshot channel and rejects chan
 
   await assertChannelFailure('channel-cli-mismatch', {}, { cliVersion: '9.9.5-other' });
   await assertChannelFailure('release-tag-mismatch', { releaseTag: 'v9.9.5-other' }, {});
-  await assertChannelFailure('starter-mismatch', { releaseStarterVersion: '0.2.0-SNAPSHOT' }, {});
+  await assertChannelFailure('starter-mismatch', { releaseStarterVersion: '0.2.0' }, {});
+  await assertChannelFailure('invalid-starter-version', {}, { starterVersion: 'latest' });
   await assertChannelFailure('asset-mismatch', { manifestDigest: '0'.repeat(64) }, {});
   await assertChannelFailure('channel-signature', {}, { signingKey: wrongKeys.privateKey });
   await assertChannelFailure('legacy-release-schema', { schemaVersion: 1, omitSource: true }, {});