You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 7e03bf3
Browse filesBrowse the repository at this point in the historyBrowse files
stlc-bot
committed
fix(api): reject timeoutMS too short for waitForMs
Copy file name to clipboardExpand all lines: pkg/cmd/web.go
+4-4Lines changed: 4 additions & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -316,7 +316,7 @@ var webScreenshot = requestflag.WithInnerFlags(cli.Command{
316
316
},
317
317
&requestflag.Flag[*int64]{
318
318
Name: "wait-for-ms",
319
-
Usage: "Optional browser wait time in milliseconds after initial page load before taking the screenshot. Min: 0. Max: 30000 (30 seconds). Defaults to 3000 ms when omitted.",
319
+
Usage: "Optional browser wait time in milliseconds after initial page load before taking the screenshot. Min: 0. Max: 30000 (30 seconds). Defaults to 3000 ms when omitted. When combined with timeoutMS, timeoutMS must be at least waitForMs + 10000 ms; a shorter deadline is rejected with 400 TIMEOUT_TOO_SHORT_FOR_WAIT.",
320
320
Default: requestflag.Ptr[int64](3000),
321
321
QueryPath: "waitForMs",
322
322
},
@@ -689,7 +689,7 @@ var webWebScrapeHTML = requestflag.WithInnerFlags(cli.Command{
689
689
},
690
690
&requestflag.Flag[*int64]{
691
691
Name: "wait-for-ms",
692
-
Usage: "Optional browser wait time in milliseconds after initial page load. Min: 0. Max: 30000 (30 seconds).",
692
+
Usage: "Optional browser wait time in milliseconds after initial page load. Min: 0. Max: 30000 (30 seconds). When combined with timeoutMS, timeoutMS must be at least waitForMs + 10000 ms; a shorter deadline is rejected with 400 TIMEOUT_TOO_SHORT_FOR_WAIT.",
693
693
QueryPath: "waitForMs",
694
694
},
695
695
&requestflag.Flag[string]{
@@ -776,7 +776,7 @@ var webWebScrapeImages = requestflag.WithInnerFlags(cli.Command{
776
776
},
777
777
&requestflag.Flag[*int64]{
778
778
Name: "wait-for-ms",
779
-
Usage: "Optional browser wait time in milliseconds after initial page load before collecting images. Min: 0. Max: 30000 (30 seconds).",
779
+
Usage: "Optional browser wait time in milliseconds after initial page load before collecting images. Min: 0. Max: 30000 (30 seconds). When combined with timeoutMS, timeoutMS must be at least waitForMs + 10000 ms; a shorter deadline is rejected with 400 TIMEOUT_TOO_SHORT_FOR_WAIT.",
780
780
QueryPath: "waitForMs",
781
781
},
782
782
},
@@ -909,7 +909,7 @@ var webWebScrapeMd = requestflag.WithInnerFlags(cli.Command{
909
909
},
910
910
&requestflag.Flag[*int64]{
911
911
Name: "wait-for-ms",
912
-
Usage: "Optional browser wait time in milliseconds after initial page load before converting the page to Markdown. Min: 0. Max: 30000 (30 seconds).",
912
+
Usage: "Optional browser wait time in milliseconds after initial page load before converting the page to Markdown. Min: 0. Max: 30000 (30 seconds). When combined with timeoutMS, timeoutMS must be at least waitForMs + 10000 ms; a shorter deadline is rejected with 400 TIMEOUT_TOO_SHORT_FOR_WAIT.",
0 commit comments