fix(config): preserve custom ollama settings when OLLAMA_BASE_URL is set - #75
Open
yozlog wants to merge 1 commit into
Open
fix(config): preserve custom ollama settings when OLLAMA_BASE_URL is set#75yozlog wants to merge 1 commit into
yozlog wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, when a custom JSON configuration file (e.g.
/app/config/openclaw.json) defines custom models for the Ollama provider, setting theOLLAMA_BASE_URLenvironment variable unconditionally overwrites the entireconfig.models.providers.ollamaobject.This behavior clears out any user-defined models or advanced settings, forcing the configuration back to a hardcoded default containing only
llama3.3.Solution
Updated
scripts/configure.jsto perform a conditional merge for the Ollama provider.Impact
Users can now safely mount custom
.jsonconfigurations to manage their Ollama model lists while still utilizingdocker-compose.ymlenvironment variables (OLLAMA_BASE_URL) to define the connection endpoint.