Repository navigation
Sync upstream CLI 1.0.92-3 and BYOK telemetry - #217
Merged
Merged
Conversation
Port provider identity and BYOK event metadata while retaining experimental boundaries. Keep the SDK version unchanged and do not cut a release. Upstream: github/copilot-sdk@ef04633 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Inventory the complete Node public surface, classify every delta, and preserve historical certification. Anchor local artifacts to the verified implementation without changing release state. Upstream: github/copilot-sdk@ef04633 Implementation: cca3ca5 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Exact-pin upstream parity, deterministic regeneration, and real-CLI validation remain independently unverified and require human confirmation.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the Clojure SDK’s CLI/schema compatibility to 1.0.92-3 and adds BYOK provider telemetry while preserving experimental boundaries and library version 1.0.16.0.
Changes:
- Adds validated provider identity with shared serialization across session builders.
- Preserves extensible BYOK event metadata and opaque progress keys.
- Updates schemas, contract tests, API documentation, and upstream certification references.
| File | Description |
|---|---|
| test/github/copilot_sdk/integration/upstream_1_0_92_3_test.clj | Tests provider contracts and event preservation. |
| test/github/copilot_sdk/e2e_test.clj | Tests telemetry through a real CLI. |
| src/github/copilot_sdk/specs.clj | Defines configuration and telemetry contracts. |
| src/github/copilot_sdk/generated/event_metadata.clj | Preserves opaque progress keys. |
| src/github/copilot_sdk/client.clj | Shares provider serialization and translates identity. |
| schemas/session-events.schema.json | Adds upstream event fields. |
| schemas/README.md | Updates schema provenance. |
| resources/github/copilot_sdk/api_surface.edn | Records three new public specs. |
| doc/upstream-doc-gap-matrix.md | Documents experimental exclusions. |
| doc/reference/API.md | Documents provider and event contracts. |
| doc/index.md | Links the new architecture decision. |
| doc/auth/byok.md | Explains telemetry identity and examples. |
| doc/api/topic-manifest.edn | Registers the new documentation topic. |
| doc/api/style.html | Refreshes generated topic navigation. |
| doc/api/overview.html | Refreshes generated topic navigation. |
| doc/api/dynamic-workflows.html | Refreshes generated topic navigation. |
| doc/api/doc-auth-index.html | Refreshes generated topic navigation. |
| doc/api/debugging.html | Refreshes generated topic navigation. |
| doc/api/custom-agents.html | Refreshes generated topic navigation. |
| doc/api/codegen.html | Refreshes generated topic navigation. |
| doc/api/azure-managed-identity.html | Refreshes generated topic navigation. |
| doc/api/2026-10-04-byok-provider-telemetry.html | Renders the new architecture decision. |
| doc/api/2026-10-02-transcript-recovery-and-owned-exit.html | Refreshes generated topic navigation. |
| doc/api/2026-09-30-model-policy-and-lifecycle-sync.html | Refreshes generated topic navigation. |
| doc/api/2026-09-27-dynamic-workflow-migration.html | Refreshes generated topic navigation. |
| doc/api/2026-08-10-host-owned-inference-boundary.html | Refreshes generated topic navigation. |
| doc/api/2026-08-08-query-seq-scoped-lifecycle.html | Refreshes generated topic navigation. |
| doc/adr/2026-10-04-byok-provider-telemetry.md | Explains separate input and telemetry contracts. |
| CHANGELOG.md | Records unreleased telemetry and compatibility changes. |
| .github/workflows/ci.yml | Pins upstream validation to the target commit. |
| .copilot-schema-version | Advances the schema pin. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Sync the CLI/schema compatibility pin to
1.0.92-3and recertify against github/copilot-sdk at the exact target, preserving the historical upstream baseline.:model-provideras a closed keyword input, with exact underscore-separated wire values, omission preservation, and rejection of explicitnil. One serializer serves create/resume/channel/join and the existing experimental named-provider registry without changing its status.:model-providerand:byok-kindevent metadata as extensible strings on assistant usage and model-call failures. Live and historical conversion agree; configuration identity does not change model selection, transport, or authentication.Boundaries
New experimental
setTools, structured tool-progress metadata, Auto routing explanations, and generated MCP prompt/OAuth controls do not enlarge the curated stable API. Private schema conversion preserves opaque progress keys; internal tool-definition diagnostics stay wire-only. Runtime-owned attribution, telemetry ownership, memory retrieval, MCP reconnection, and subagent prompt persistence retain existing SDK builders.The library version remains
1.0.16.0. This PR creates no release, tag, or deployment.Validation and review
COPILOT_UPSTREAM_VALIDATION=true bb test: passed, including the complete 1,057-test suite with the new certification. The corrected exact-pin certification was rerun after review: 5 tests / 651 assertions passed.bb ci:fullwith the verified CLI1.0.92-3: passed authenticated E2E tests, every portable example, documentation validation, and the JAR build. Validation used an isolated runtime/home with built-in MCPs disabled.