Skip to content

Commit 964a851

Browse files
jplexercodex
andcommitted
shell: default Getafix backlight to Battery Saver
Select Battery Saver as the default preset on Getafix and initialize brightness and dynamic mode from that preset. Fresh settings use 25% brightness and Dim dynamic mode; saved preferences still take precedence. Fixes FIRM-4392 Co-Authored-By: GPT-6 Astra <noreply@openai.com> Signed-off-by: Joshua Jun <lets@throw.rocks>
1 parent 77c56b0 commit 964a851

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

src/fw/shell/normal/prefs.c

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ static uint8_t s_motion_sensitivity = 55; // Default to Medium
102102

103103
#ifdef CONFIG_DYNAMIC_BACKLIGHT
104104
#define PREF_KEY_BACKLIGHT_DYNAMIC_MODE "lightDynamicMode"
105-
static uint8_t s_backlight_dynamic_mode = BacklightDynamicMode_Standard;
105+
static uint8_t s_backlight_dynamic_mode; // default set in shell_prefs_init()
106106

107107
// Removed prefs; the key defines survive only so migration can convert/scrub
108108
// stored values.
@@ -111,7 +111,12 @@ static uint8_t s_backlight_dynamic_mode = BacklightDynamicMode_Standard;
111111
#endif
112112

113113
#define PREF_KEY_BACKLIGHT_PRESET "lightPreset"
114-
static uint8_t s_backlight_preset = BacklightPreset_Standard;
114+
#ifdef CONFIG_BOARD_GETAFIX
115+
#define BACKLIGHT_PRESET_DEFAULT BacklightPreset_BatterySaver
116+
#else
117+
#define BACKLIGHT_PRESET_DEFAULT BacklightPreset_Standard
118+
#endif
119+
static uint8_t s_backlight_preset = BACKLIGHT_PRESET_DEFAULT;
115120

116121
// The settings each preset applies; Advanced has no entry since it leaves
117122
// the underlying settings untouched.
@@ -972,11 +977,14 @@ static void prv_convert_deprecated_dynamic_intensity_key(SettingsFile *file) {
972977
static void prv_pref_set(const char* key, const void *value, size_t val_len);
973978

974979
void shell_prefs_init(void) {
980+
#ifdef CONFIG_DYNAMIC_BACKLIGHT
981+
s_backlight_dynamic_mode = s_backlight_preset_settings[BACKLIGHT_PRESET_DEFAULT].dynamic_mode;
982+
#endif
975983
#ifdef CONFIG_QEMU
976984
s_backlight_intensity = BACKLIGHT_INTENSITY_MAX; // Blinding
977985
#else
978-
// Match the Standard preset so fresh devices report Mode: Standard.
979-
s_backlight_intensity = s_backlight_preset_settings[BacklightPreset_Standard].intensity;
986+
// Match the default preset so fresh devices report the selected mode.
987+
s_backlight_intensity = s_backlight_preset_settings[BACKLIGHT_PRESET_DEFAULT].intensity;
980988
#endif
981989
s_backlight_ambient_threshold = BOARD_CONFIG.ambient_light_dark_threshold;
982990
#ifdef CONFIG_BACKLIGHT_HAS_COLOR

0 commit comments

Comments
 (0)