Conversation
Collaborator
|
Sure ok without warning |
Author
|
@gmarull should i update the PR? to remove the warning? |
Collaborator
|
yes |
parc94
force-pushed
the
feat/5min-hr-interval
branch
from
September 18, 2026 17:40
268c72d to
5db627c
Compare
parc94
changed the title
Add a 5-minute measurement interval option to background heart rate monitoring in Settings -> Health. Note from contributor: I am by no means a developer, but as an original Pebble owner I wanted to contribute back to the PebbleOS community. I vibe coded this and tested it myself in QEMU. Story time: I used a Xiaomi band that supported 5-minute HR tracking while investigating heart concerns (which thankfully turned out to be nothing). Having a 5-minute sampling interval on Pebble was something I really missed and wanted to bring to PebbleOS, hoping it helps others who want finer-grained heart rate tracking. Co-Authored-By: Gemini 3.8 Flash <noreply@google.com> Signed-off-by: Pedro Reyes <peter140394@gmail.com>
parc94
force-pushed
the
feat/5min-hr-interval
branch
from
September 18, 2026 23:07
5db627c to
d599be2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a 5 Minutes interval option to background heart rate monitoring in Settings > Health.
Per maintainer feedback (@gmarull / @ericmigi), the battery warning confirmation dialog has been removed — selecting 5 Minutes now directly applies the setting like any other interval option. The branch has also been rebased onto the latest
main.Background & Story
I am an original Pebble owner and wanted to contribute back to the community managing PebbleOS. By no means am I an experienced firmware developer — this feature was vibe coded with AI assistance and thoroughly tested in the QEMU emulator.
The motivation behind this: I previously used a Xiaomi Band that tracked heart rate every 5 minutes when I was monitoring my HR (I had concerns about a possible heart issue at the time, which fortunately turned out to be completely fine!). I found having that 5-minute granularity very reassuring, and hopefully having this option in PebbleOS will be helpful to others as well.
Changes
include/pbl/services/activity/activity.h: AddHRMonitoringInterval_5MinbeforeHRMonitoringIntervalCount(preserving backwards compatibility of enum values 0–3).src/fw/services/activity/activity.c: Return5 * SECONDS_PER_MINUTEinprv_get_hrm_period_sec()for the 5-minute interval.src/fw/apps/system/settings/health.c:Testing
pbl test— 333/333 tests passed.gitlintagainstupstream/main.qemu_emery):