shell: configure Standard backlight intensity per board - #2077
Merged
jplexer merged 1 commit intoSep 16, 2026
Merged
Conversation
jplexer
marked this pull request as ready for review
September 15, 2026 20:46
gmarull
reviewed
Sep 15, 2026
gmarull
left a comment
gmarull
left a comment
Member
There was a problem hiding this comment.
shouldn't we modify standard instead?
jplexer
force-pushed
the
codex/firm-4392-getafix-battery-saver
branch
from
September 16, 2026 09:41
964a851 to
3076569
Compare
jplexer
changed the title
gmarull
approved these changes
Sep 16, 2026
jplexer
changed the title
jplexer
force-pushed
the
codex/firm-4392-getafix-battery-saver
branch
from
September 16, 2026 10:52
3076569 to
d08e405
Compare
Add BACKLIGHT_STANDARD_INTENSITY with a 1-100 range and a default of 50. Set it to 25 in the shared Getafix board configuration and use it for the Standard preset, which also supplies fresh-device brightness. Keep Standard as the default mode and preserve saved preferences. Battery Saver retains its Dim curve and other boards retain 50%. Fixes FIRM-4392 Co-Authored-By: GPT-6 Astra <noreply@openai.com> Signed-off-by: Joshua Jun <lets@throw.rocks>
jplexer
force-pushed
the
codex/firm-4392-getafix-battery-saver
branch
from
September 16, 2026 11:04
d08e405 to
9dbfafa
Compare
gmarull
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Getafix's Standard backlight preset uses 50% brightness. Add
CONFIG_BACKLIGHT_STANDARD_INTENSITY(range 1–100, default 50) and set it to 25 in Getafix's shared board defconfig. The Standard preset reads this configuration directly, so both Getafix revisions use 25% for fresh settings and when Standard is selected.Standard remains the default mode with its Standard dynamic curve. Battery Saver retains its Dim curve, and other boards retain their existing defaults. Saved preferences still take precedence; existing watches storing 50% may report Advanced until Standard is selected again.
Fixes FIRM-4392
The host test build defines the new setting as 50%, matching the Kconfig default, since it does not load firmware Kconfig.
Validation
prefs.cusing the newly generated Getafix DVT2 configuration header and the existing build's compiler settings.prefs.cwith the new setting; preferences tests passed using the rebuilt object. The local activity test link was blocked by incompatible cached objects from newer source.git diff --checkand commitgitlintpassed.rsvg-convert.AI-assisted implementation using GPT-6 Astra.