fix(corsair): pass a test kek after resolveKekAtInit - #1449
fix(corsair): pass a test kek after resolveKekAtInit#1449Dhirenderchoudhary wants to merge 1 commit into
Conversation
|
@Dhirenderchoudhary is attempting to deploy a commit to the corsair Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe test configurations in hook and retry-recovery tests now use ChangesTest KEK Configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR updates database-backed tests to use the required non-empty test KEK without changing production behavior or public contracts. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryUpdates two Corsair test suites to provide a valid non-empty test KEK when initializing Corsair with a database.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The changed test configuration satisfies the non-empty KEK requirement for database-backed Corsair instances, while each test retains isolated in-memory storage. Important Files Changed
Reviews (1): Last reviewed commit: "fix(corsair): pass a test kek after reso..." | Re-trigger Greptile |
|
Closing as #1450 same fix done by @yuvrxj-afk with better approach |
Summary
kekis empty and a database is set.hooksandretry-recoverstill passedkek: '', so every plugin PR that touchesconstants.tsfailscorsair#test.kek: 'test-kek'like the other core tests.Test plan
corsair#test(hooks.test.ts,retry-recover.test.ts)Summary by CodeRabbit