Update dependecies - #46
StevenvdSchoot wants to merge 6 commits into
Conversation
6df3a3a to
d487dd2
Compare
Neither version removed any features or introduced any policies that are needed for this project: - Version 24: https://cmake.org/cmake/help/latest/release/3.24.html - Version 25: https://cmake.org/cmake/help/latest/release/3.25.html
d487dd2 to
49b7f9c
Compare
49b7f9c to
007424d
Compare
|
|
||
| include(Catch) | ||
|
|
||
| add_library(catch_main OBJECT catch_main.cpp) |
There was a problem hiding this comment.
I've kept this lines to avoid changing to Catch2::Catch2WithMain in all other target_link_libraries. It worked anyway.
There was a problem hiding this comment.
Could you elaborate on what the benefits are of keeping the catch_main target? When keeping it it just serves as an alias for Catch2::CatchWithMain. My initial thought was to remove it, since it shortens and simplifies the cmake file and thus servers the purpose of a minimal starter project better.
There was a problem hiding this comment.
I think none to be honest. But you see that's an project_options include. I'm not sure if it changes something or not.
| include(Catch) | ||
|
|
||
| add_library(catch_main OBJECT catch_main.cpp) | ||
| target_link_libraries(catch_main PUBLIC Catch2::Catch2) |
There was a problem hiding this comment.
Changed only here to target_link_libraries(catch_main PUBLIC Catch2::Catch2WithMain)
|
Can anyone with commit permission take a look on this? It's really useful. |
2 participants
Updated some dependecies: