Repository navigation
fix zsh completion - #659
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes zsh completion argument handling so multi-word command lines are passed to resticprofile complete as distinct arguments (preventing zsh from joining slices into a single token), and adds integration tests to prevent regressions.
Changes:
- Update zsh completion to use
${(@)words[2,-1]}when invokingresticprofile complete, preserving word boundaries. - Update restic-delegation argument rebuilding to iterate over
${(@)words[2,-1]}as separate words. - Add zsh shell-completion integration tests covering flags after a built-in command and after a prefixed delegated subcommand.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| contrib/completion/zsh-completion.zsh | Ensures zsh passes the words slice as separate argv entries to resticprofile complete, fixing completion for flags after subcommands. |
| completion_shell_test.go | Adds zsh integration tests that exercise multi-word completion paths (built-in and restic-delegated). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #659 +/- ##
==========================================
- Coverage 80.96% 80.93% -0.03%
==========================================
Files 162 162
Lines 12122 12131 +9
==========================================
+ Hits 9814 9818 +4
- Misses 1810 1814 +4
- Partials 498 499 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
No description provided.