Repository navigation
Conversation
restic accepts "unlimited" as an alternative to a count for the integer keep-* retention flags, but the generated JSON schema only allowed integers. Allow the string value "unlimited" for these flags, and filter enum values per schema type so the "unlimited" enum only applies to the string branch of the schema.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #449
restic accepts
unlimitedas an alternative to a count for the integerkeep-*retention flags (as documented in the restic help text), but the generated JSON schema only allowed integers, so editors flagged valid configurations like:Changes
config: for integerkeep-*restic flags, the property info now also allows the string valueunlimited(other integer flags such aslimit-downloadare unchanged).config/jsonschema: enum values are now filtered per schema type, mirroring how defaults and examples are already filtered. Without this, theunlimitedenum would leak into theintegerbranch of the schema and make every numeric value invalid.The generated schema renders
keep-dailyas:{ "oneOf": [ { "type": "integer" }, { "type": "string", "enum": ["unlimited"] } ] }Testing
keep-*vslimit-downloadvs durationkeep-within)oneOfforkeep-dailyin the retention section, and thatlimit-downloadstays integer-onlyEnumcase ofTestConfigureBasicInfofor the per-type filteringgo test ./config/...passes;golangci-lint run ./config/...(v2.12.2) reports 0 issues