Revert unnecessary DB connection changes

Author: crocodilestick

CONTRIBUTORS

@@ -303,7 +303,7 @@ Copyright (C) 2024-2025 Calibre-Web Automated contributors
 - zhiyue (1 commits)
 # Fork Contributors (crocodilestick/calibre-web-automated)
 
-- crocodilestick (784 commits)
+- crocodilestick (783 commits)
 - jmarmstrong1207 (73 commits)
 - demitrix (30 commits)
 - sirwolfgang (29 commits)

cps/db.py

@@ -737,22 +737,8 @@ def setup_db(cls, config_calibre_dir, app_db_path):
             inst.init_session()
 
         # Ensure progress syncing tables exist in metadata.db (book checksums)
-        # Use a direct connection to ensure the table is created in the file, not in-memory
-        try:
-            # Import inside try block to handle potential circular imports or missing modules gracefully
-            from .progress_syncing.models import ensure_calibre_db_tables
-            
-            # Verify dbpath exists
-            if os.path.exists(dbpath):
-                with sqlite3.connect(dbpath, timeout=30) as direct_conn:
-                    ensure_calibre_db_tables(direct_conn)
-            else:
-                log.error(f"Cannot ensure tables: metadata.db not found at {dbpath}")
-        except Exception as e:
-            # Log to both app log and stderr to ensure visibility in Docker logs
-            import sys
-            sys.stderr.write(f"ERROR: Failed to ensure progress syncing tables: {e}\n")
-            log.error(f"Failed to ensure progress syncing tables: {e}")
+        from .progress_syncing.models import ensure_calibre_db_tables
+        ensure_calibre_db_tables(conn)
 
         cls._init = True
 

cps/progress_syncing/models.py

@@ -87,11 +87,9 @@ def execute_sql(sql):
         try:
             db_list = execute_sql("PRAGMA database_list").fetchall()
             # Row format: (seq, name, file)
-            # Log the database list for debugging
-            log.debug(f"Database list: {[str(row) for row in db_list]}")
             is_calibre_attached = any(str(row[1]) == 'calibre' for row in db_list)
-        except Exception as e:
-            log.warning(f"Failed to check database list: {e}")
+        except Exception:
+            is_calibre_attached = False
 
         table_prefix = "calibre." if is_calibre_attached else ""
         table_name = f"{table_prefix}book_format_checksums"