Feature/calibre content server - #1507
Closed
benjitobz wants to merge 2 commits into
Closed
Conversation
Author
|
Noticed some issues with this, going to close and reopen once I figure out a better approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: I created a PR in Calibre-Web and Calibre-Web-Automated, the implementation is the same across all three.
Been meaning to do this for awhile. Calibre-Web already knows where the library and the calibre binaries are, but there's no way to run calibre's own content server from it.
What this adds
Calibre-Web runs
calibre-serveras a child process, configured under BasicConfiguration → Feature Configuration:
it's ticked — same
data-control/data-relatedpattern as the Kobo and upload settings.--enable-local-write --trusted-ips 0.0.0.0/0,::/0.--enable-auth --auth-mode basicand a generated userdb, so ordinary HTTP clients can authenticate.
and stops on shutdown and before the
os.execvrestart so the new process doesn't hita port conflict.
Port, username and password can also come from
CALIBRE_SERVER_PORT,CALIBRE_SERVER_USERNAMEandCALIBRE_SERVER_PASSWORDfor docker setups. Env values win,never get written to the db, and their fields render disabled.