Fix/graceful shutdown - #11
Merged
Merged
Conversation
main.go ended at log.Fatal(ListenAndServe), so SIGTERM killed requests mid-flight and the os.Exit skipped every defer, including db.Close(). That left the SQLite WAL uncheckpointed: api.db stayed 4096 bytes while the -wal file held the whole schema. Co-Authored-By: Claude Code <noreply@anthropic.com>
Four comments asserted it and are now false. shiplog's async-sink argument changed reasoning rather than wording: the missing pieces are the buffer and the flush policy, not a lifecycle to hang off. Co-Authored-By: Claude Code <noreply@anthropic.com>
Records the end-to-end verification (SIGTERM, then the database read read-only with no sidecar files: 7 migrations, 1 user, 2 sessions), and retires the owed items in Tiers 3, 5 and 6 and in Tier 7's spec. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.