Fixed pointing runs - #7
Open
IevgenVovk wants to merge 29 commits into
Open
Conversation
zero predicted events was leading to NaN in the sampling probability (as weights.sum() == 0) and the subsequent crash.
it's children are now expected to implement the tel_pos_to_altaz() method to make predict() work.
IevgenVovk
marked this pull request as ready for review
October 30, 2023 05:30
…ping time settings.
final Alt/Az transformation (fixed time was leading to a wrong RA assigned to some of the runs).
…ssible scheduled on the first day
…_pos_lead directly leads to wrong position once intervals are sliced and tel_pos_lead no longer corresponds to the interval start.
Collaborator
Author
|
@mstrzys , any comments on this PR? |
Collaborator
Author
|
@mstrzys , I've fixed the merge conflicts; this MR is ready to merge if you approve. |
mstrzys
reviewed
Aug 5, 2024
Collaborator
There was a problem hiding this comment.
Is there a reason why you implemented your own interpolation method instead of using the one from astropy?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds simulation of the fixed pointing (in alt/az) runs.
Changes:
FixedPointingDataRun: new class implementing the fixed pointing simulation;FixedObsGenerator: new class generating runs based on the requested pointing and exposure;