-
Notifications
You must be signed in to change notification settings - Fork 0
Implement VM #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Implement VM #24
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
659c7f2
Implement VM
caleb-bit 8d58533
Rename error to emitError
caleb-bit 028c2f6
Use toLongOrNull
caleb-bit 6e21097
Don't log fcm token
caleb-bit 91352ee
Fix caching issue
caleb-bit 6025c86
Use getQuantityString for plural text
caleb-bit da585fa
Organize into folders
caleb-bit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
app/src/main/java/com/cornellappdev/coursegrab/CourseDetailsViewModel.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| package com.cornellappdev.coursegrab | ||
|
|
||
| import android.util.Log | ||
| import androidx.lifecycle.ViewModel | ||
| import androidx.lifecycle.viewModelScope | ||
| import com.cornellappdev.coursegrab.networking.CourseGrabRepository | ||
| import dagger.hilt.android.lifecycle.HiltViewModel | ||
| import kotlinx.coroutines.channels.Channel | ||
| import kotlinx.coroutines.flow.receiveAsFlow | ||
| import kotlinx.coroutines.launch | ||
| import javax.inject.Inject | ||
|
|
||
| @HiltViewModel | ||
| class CourseDetailsViewModel @Inject constructor( | ||
| private val repository: CourseGrabRepository | ||
| ) : ViewModel() { | ||
|
|
||
| private val _trackingErrors = Channel<String>(Channel.BUFFERED) | ||
| val trackingErrors = _trackingErrors.receiveAsFlow() | ||
|
|
||
| fun addCourse(courseId: Int) = track(courseId, adding = true) | ||
|
|
||
| fun removeCourse(courseId: Int) = track(courseId, adding = false) | ||
|
|
||
| private fun track(courseId: Int, adding: Boolean) { | ||
| viewModelScope.launch { | ||
| val result = if (adding) repository.addTracking(courseId) | ||
| else repository.removeTracking(courseId) | ||
|
|
||
| result.onFailure { error -> | ||
| Log.e(TAG, "Failed to ${if (adding) "track" else "untrack"} $courseId", error) | ||
| _trackingErrors.send( | ||
| error.message ?: if (adding) "Couldn't track that course." | ||
| else "Couldn't remove that course." | ||
| ) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private companion object { | ||
| const val TAG = "CourseDetailsViewModel" | ||
| } | ||
| } |
7 changes: 7 additions & 0 deletions
7
app/src/main/java/com/cornellappdev/coursegrab/CourseGrabApplication.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package com.cornellappdev.coursegrab | ||
|
|
||
| import android.app.Application | ||
| import dagger.hilt.android.HiltAndroidApp | ||
|
|
||
| @HiltAndroidApp | ||
| class CourseGrabApplication : Application() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: not sure if this rly matters in the end but isn't
activity-ktx:1.8.0older?