Skip to content

Commit 1ad57cd

Browse files
committed
Parameterize previews
1 parent edf83c0 commit 1ad57cd

2 files changed

Lines changed: 31 additions & 31 deletions

File tree

app/src/main/java/com/cornellappdev/score/screen/HighlightsSearchScreen.kt

Lines changed: 29 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,12 @@ import androidx.compose.runtime.Composable
1212
import androidx.compose.ui.Modifier
1313
import androidx.compose.ui.graphics.Color
1414
import androidx.compose.ui.tooling.preview.Preview
15+
import androidx.compose.ui.tooling.preview.PreviewParameter
16+
import androidx.compose.ui.tooling.preview.PreviewParameterProvider
1517
import androidx.compose.ui.unit.dp
1618
import com.cornellappdev.score.R
1719
import com.cornellappdev.score.components.EmptyStateBox
20+
import com.cornellappdev.score.components.ScorePreview
1821
import com.cornellappdev.score.components.highlights.HighlightsCardLazyColumn
1922
import com.cornellappdev.score.components.highlights.HighlightsScreenSearchFilterBar
2023
import com.cornellappdev.score.components.highlights.RecentSearches
@@ -23,6 +26,7 @@ import com.cornellappdev.score.model.Sport
2326
import com.cornellappdev.score.theme.Style.bodyNormal
2427
import com.cornellappdev.score.theme.Style.heading2
2528
import com.cornellappdev.score.util.highlightsList
29+
import com.cornellappdev.score.util.recentSearchList
2630
import com.cornellappdev.score.util.sportList
2731

2832
@Composable
@@ -70,38 +74,32 @@ fun HighlightsSearchScreen(
7074
}
7175
}
7276

73-
@Preview
74-
@Composable
75-
private fun HighlightsSearchScreenStartStatePreview() {
76-
HighlightsSearchScreen(
77-
sportList,
78-
listOf("Columbia", "Men's ice hockey", "Late goal lifts No.6 men’s hockey"),
79-
highlightsList,
80-
"",
81-
"Search All Highlights"
82-
)
83-
}
77+
data class HighlightsSearchScreenPreviewData(
78+
val sportList: List<Sport>,
79+
val recentSearchList: List<String>,
80+
val query: String
81+
)
8482

85-
@Preview
86-
@Composable
87-
private fun HighlightsSearchScreenQueryMissPreview() {
88-
HighlightsSearchScreen(
89-
sportList,
90-
listOf("Columbia", "Men's ice hockey", "Late goal lifts No.6 men’s hockey"),
91-
highlightsList,
92-
"Sports",
93-
"Search All Highlights"
94-
)
83+
class HighlightsSearchScreenPreviewProvider : PreviewParameterProvider<HighlightsSearchScreenPreviewData> {
84+
override val values: Sequence<HighlightsSearchScreenPreviewData> = sequence {
85+
yield(HighlightsSearchScreenPreviewData(sportList, recentSearchList, ""))
86+
yield(HighlightsSearchScreenPreviewData(sportList, recentSearchList, "Sports"))
87+
yield(HighlightsSearchScreenPreviewData(sportList, recentSearchList, "Hockey"))
88+
}
9589
}
9690

97-
@Preview
91+
@Preview(showBackground = true)
9892
@Composable
99-
private fun HighlightsSearchScreenQueryHitPreview() {
100-
HighlightsSearchScreen(
101-
sportList,
102-
listOf("Columbia", "Men's ice hockey", "Late goal lifts No.6 men’s hockey"),
103-
highlightsList,
104-
"Hockey",
105-
"Search All Highlights"
106-
)
107-
}
93+
private fun HighlightScreenPreview(
94+
@PreviewParameter(HighlightsSearchScreenPreviewProvider::class) previewData: HighlightsSearchScreenPreviewData
95+
) {
96+
ScorePreview {
97+
HighlightsSearchScreen(
98+
sportList = previewData.sportList,
99+
recentSearchList = previewData.recentSearchList,
100+
highlightsList = highlightsList,
101+
query = previewData.query,
102+
header = "Search All Highlights"
103+
)
104+
}
105+
}

app/src/main/java/com/cornellappdev/score/util/TestingConstants.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,8 @@ val sportSelectionList = listOf(
225225
SportSelection.SportSelect(Sport.FIELD_HOCKEY)
226226
)
227227

228+
val recentSearchList = listOf("Columbia", "Men's ice hockey", "Late goal lifts No.6 men’s hockey")
229+
228230
//Mixed type
229231
val highlightsList = listOf(
230232
HighlightData.Video

0 commit comments

Comments
 (0)