Skip to content

Commit 3ef0033

Browse files
committed
Show review result steppers only for manual runs
1 parent f67b992 commit 3ef0033

2 files changed

Lines changed: 4 additions & 10 deletions

File tree

src/views/steps/renderBrewing.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,9 @@ function renderReview(container: HTMLElement, ctx: StepRenderContext): void {
187187
const staticChart = new BrewProfileChart(chartContainer);
188188
ctx.registerCleanup(() => staticChart.destroy());
189189
staticChart.renderStatic(points);
190+
} else {
191+
renderManualResultSteppers(container, ctx);
190192
}
191-
renderManualResultSteppers(container, ctx);
192193

193194
const controls = container.createDiv({ cls: 'brewing-controls' });
194195
const redoBtn = controls.createEl('button', { text: t('brew.redoBrew'), cls: 'brewing-ctrl-btn brew-flow-redo-btn' });

tests/views/steps/renderBrewing.test.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -270,19 +270,12 @@ describe('renderBrewing phase controls', () => {
270270
expect(container.querySelector('.brew-flow-stop-btn')).toBeNull();
271271
});
272272

273-
it('review with a recorded profile also shows prefilled time and yield steppers', () => {
273+
it('review with a recorded profile shows the chart without result steppers', () => {
274274
const flowState = makeReviewFlowWithPoints({ time: 130, yield: 210 });
275275
const harness = makeHarness(flowState, { connected: true, points: [{ t: 1, w: 10 }] });
276276
renderBrewing(harness.container, harness.ctx);
277277
expect(harness.container.querySelector('.brew-profile-container')).not.toBeNull();
278-
const steppers = harness.container.querySelectorAll<HTMLElement>('.brew-flow-form .cubicj-stepper');
279-
expect(steppers).toHaveLength(2);
280-
expect(steppers[0].querySelector('.cubicj-stepper-value')?.textContent).toBe('130s');
281-
expect(steppers[1].querySelector('.cubicj-stepper-value')?.textContent).toBe('210.0g');
282-
steppers[0].querySelectorAll<HTMLButtonElement>('.cubicj-stepper-btn')[1].click();
283-
steppers[1].querySelectorAll<HTMLButtonElement>('.cubicj-stepper-btn')[1].click();
284-
expect(flowState.selection.time).toBe(131);
285-
expect(flowState.selection.yield).toBe(210.1);
278+
expect(harness.container.querySelectorAll('.brew-flow-form .cubicj-stepper')).toHaveLength(0);
286279
});
287280

288281
it('review without a profile renders manual time/yield steppers seeded from selection', () => {

0 commit comments

Comments
 (0)