@@ -687,12 +687,12 @@ def test_setup_optimizer_passes_none_pg_collection_when_not_provided(
687687 assert call_kwargs ["pg_collection" ] is None
688688
689689 @patch ("megatron.bridge.training.optim.get_model_config" )
690- @patch ("megatron.bridge.training.optim.get_megatron_muon_optimizer " )
690+ @patch ("megatron.bridge.training.optim.get_megatron_optimizer " )
691691 @patch ("megatron.bridge.training.optim.OptimizerParamScheduler" )
692692 def test_setup_optimizer_passes_pg_collection_to_muon_optimizer (
693- self , mock_scheduler , mock_get_muon_optimizer , mock_get_model_config
693+ self , mock_scheduler , mock_get_optimizer , mock_get_model_config
694694 ):
695- """Test that setup_optimizer passes pg_collection to muon optimizer ."""
695+ """Test that setup_optimizer passes pg_collection for Muon construction ."""
696696 from megatron .core .optimizer import OptimizerConfig
697697
698698 from megatron .bridge .training .config import SchedulerConfig
@@ -703,7 +703,7 @@ def test_setup_optimizer_passes_pg_collection_to_muon_optimizer(
703703 mock_model = MagicMock ()
704704 mock_pg_collection = MagicMock ()
705705 mock_optimizer = MagicMock ()
706- mock_get_muon_optimizer .return_value = mock_optimizer
706+ mock_get_optimizer .return_value = mock_optimizer
707707
708708 optimizer_config = OptimizerConfig (optimizer = "muon" , lr = 1e-3 )
709709 scheduler_config = SchedulerConfig ()
@@ -717,9 +717,10 @@ def test_setup_optimizer_passes_pg_collection_to_muon_optimizer(
717717 pg_collection = mock_pg_collection ,
718718 )
719719
720- # Verify pg_collection was passed to muon optimizer
721- mock_get_muon_optimizer .assert_called_once ()
722- call_kwargs = mock_get_muon_optimizer .call_args [1 ]
720+ # Verify pg_collection was passed through the unified optimizer factory.
721+ mock_get_optimizer .assert_called_once ()
722+ call_kwargs = mock_get_optimizer .call_args [1 ]
723+ assert call_kwargs ["config" ] is optimizer_config
723724 assert call_kwargs ["pg_collection" ] == mock_pg_collection
724725
725726 @patch ("megatron.bridge.training.optim.get_model_config" )
0 commit comments