Skip to content

declaresLimitShapedKey partitions at file level, so a new limit key in a covered file needs no matrix row #324

Description

@OliverWolffGIP

Follow-up from PR #320 (merged as 93a4b3e).

declaresLimitShapedKey partitions schema descriptors by a file-level boolean, so a new limit-shaped key added to a file that already carries one needs no new Coverage Matrix row. The contract then passes without ever having seen the new key.

Impact: the declared-limit assertion coverage contract is the guard that a declared limit is actually asserted somewhere; at file granularity it silently stops guarding new keys in already-covered files — the failure mode the contract exists to prevent.

Wanted

  • Move the partition to key granularity (one row per limit-shaped key) or state explicitly in the contract doc why file granularity is sufficient.
  • A test that adding a limit-shaped key to an already limit-bearing file fails the contract until a matrix row exists.

Sites

  • doc/development/declared-limit-assertion-coverage.adoc (the contract, declaresLimitShapedKey is described around line 629)
  • api-sheriff/src/test/java/de/cuioss/sheriff/gateway/config/DocumentedSetsContractTest.java

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions