Skip to content

csv_overrides check_for_duplicates does nothing #1861

Closed

Description

@auscompgeek

I can't see what type this is supposed to be... because I don't think any items are ever assigned to this 😕

I recall this bit was in one of the other functions previously. Think this ended up being broken after a recent refactor.

Originally posted by @auscompgeek in #1851 (comment)

Activity

  1. added
    bugSomething isn't working
    talonRelated to cursorless-talon
    on Sep 7, 2023
  2. pokey commented on Sep 7, 2023

    @pokey
    Member

    oh wow nice catch 😅. looks like we are forgetting to update results_map in each iteration. We should fix and then do a manual check that it catches the bug. Ideally we could call the function with some mocks to add a real test that it catches duplicates

  3. added a commit that references this issue on Jul 26, 2025
    af35ab2
  4. added a commit that references this issue on Jul 26, 2025
    362880a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugSomething isn't workingtalonRelated to cursorless-talon

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions