You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Update argument list domains and argument iteration domains in JS and TS - #3124
I'm not a big fan of how complicated the function definitions in javascript are becoming. Or how much code duplication there is.
The motivation being that if we really want argument list domain to be the same as the function domain for all of these 25+ different patterns we really need to combined them instead of trying to recreate them in a separate argument list only definition.
I'm not a big fan of how complicated the function definitions in javascript are becoming. Or how much code duplication there is. The motivation being that if we really want argument list domain to be the same as the function domain for all of these 25+ different patterns we really need to combined them instead of trying to recreate them in a separate argument list only definition.
For some situations, you can just define @namedFunction and @argumentList in the same pattern (as you've done in a couple places). If that doesn't get us far enough we've def talked about building our own DSL on top of query syntax but that's obv bigger investment
Would be nice to have our own DSL, but I can't really say that I feel like writing that at the moment. If all languages look like this I would definitely do it immediately, but most of them are quite well behaved compared to javascript.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not a big fan of how complicated the function definitions in javascript are becoming. Or how much code duplication there is.
The motivation being that if we really want argument list domain to be the same as the function domain for all of these 25+ different patterns we really need to combined them instead of trying to recreate them in a separate argument list only definition.
@pokey Any input?