Skip to content

Sort sidebar items on label for the docs page - #3320

Merged
AndreasArvidsson merged 3 commits into
mainfrom
docLabelSort
Aug 30, 2026
Merged

AndreasArvidsson merged 3 commits into
mainfrom
docLabelSort

Conversation

@AndreasArvidsson

Copy link
Copy Markdown
Member

No description provided.

@AndreasArvidsson
AndreasArvidsson requested a review from a team as a code owner August 30, 2026 12:37
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-30T12:51:12.492791Z 2bb8bef New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: adc5ed5e4c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2bb8befce8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +77 to +82
function sortByLabel(
items: NormalizedSidebarItem[],
): NormalizedSidebarItem[] {
const normalizedItems = items.map((item): NormalizedSidebarItem =>
item.type === "category"
? { ...item, items: sortByLabel(item.items) }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add tests for recursive sidebar ordering

This introduces recursive sorting and explicit-position preservation for both autogenerated sidebars, but the commit adds no test that exercises the generator; a repo-wide search finds only the implementation and its Docusaurus configuration reference. Add focused tests covering nested label ordering and preservation of sidebarPosition, so future changes cannot silently reorder the published navigation while the site still builds successfully.

AGENTS.md reference: AGENTS.md:L48-L48

Useful? React with 👍 / 👎.

@AndreasArvidsson
AndreasArvidsson merged commit 821225c into main Aug 30, 2026
16 checks passed
@AndreasArvidsson
AndreasArvidsson deleted the docLabelSort branch August 30, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant