feat: add file navigation support

Author: mingrammer

README.md

@@ -1,20 +1,23 @@
 # Expr Language Support
 
-VS Code extension for [Expr](https://github.com/expr-lang/expr) language with syntax highlighting, intelligent formatting, and rainbow brackets.
+VS Code extension for [Expr](https://github.com/expr-lang/expr) language with syntax highlighting, intelligent formatting, rainbow brackets, and file navigation.
 
 ## Features
 
 - ✨ **Syntax Highlighting** - Full support for Expr language constructs
 - 🌈 **Rainbow Brackets** - Color-coded parentheses by nesting depth
 - 🎨 **Smart Formatting** - Auto-format with intelligent spacing and indentation
+- 🔗 **File Navigation** - Click `"*.expr"` strings to jump to referenced files
 
 ## Installation
 
-```bash
-code --install-extension expr-lang-support-0.3.0.vsix
-```
+**From VS Code Marketplace:**
+
+1. Open VS Code Extensions (`Ctrl+Shift+X` or `Cmd+Shift+X`)
+2. Search for "Expr Lang - Syntax & Formatter"
+3. Click Install
 
-Or in VS Code: `Extensions` → `...` → `Install from VSIX...`
+Or visit the [VS Code Marketplace](https://marketplace.visualstudio.com/vscode)
 
 ## Usage
 
@@ -29,7 +32,7 @@ Create a `.expr` file and start coding! Formatting: `Shift+Alt+F` (Windows/Linux
   "expr.rainbowBrackets.enabled": true,
   "[expr]": {
     "editor.formatOnSave": true,
-    "editor.defaultFormatter": "daangn.expr-lang-support"
+    "editor.defaultFormatter": "daangn-ml-data-platform.expr-lang-support"
   }
 }
 ```

packages/vscode/README.md

@@ -37,18 +37,23 @@ Complete language support for Expr language - syntax highlighting, intelligent f
   - Handles `#`, `//`, and `/* */` style comments
 - **Format on save** support (enabled by default)
 
-## Installation
+### 🔗 Expr File Navigation
+- **Go to Definition**: Cmd+Click (Mac) / Ctrl+Click (Windows) or F12 on `"*.expr"` strings to open referenced files
+- **Link Highlighting**: `.expr` file references are automatically highlighted as clickable links
+- **Works everywhere**: Supports file references in any file type (Markdown, JSON, YAML, etc.)
+- **Relative paths**: Supports relative paths like `"../data/input.expr"` or `"./config.expr"`
+- **Tooltip preview**: Hover to see the file path
 
-### Install from code
+## Installation
 
-```bash
-npm run package:vscod
-code --install-extension expr-lang-support-0.3.0.vsix
-```
+### From VS Code Marketplace
 
-### VS Code Marketplace
+1. Open VS Code
+2. Press `Ctrl+Shift+X` (Windows/Linux) or `Cmd+Shift+X` (Mac) to open Extensions
+3. Search for "Expr Lang - Syntax & Formatter"
+4. Click Install
 
-Search the "Expr Language Support" in the Marketplace tab, and install the extension.
+Or visit the [VS Code Marketplace](https://marketplace.visualstudio.com/vscode)
 
 ## Usage
 
@@ -237,7 +242,7 @@ npm run watch
   ```json
   {
     "[expr]": {
-      "editor.defaultFormatter": "daangn.expr-lang-support"
+      "editor.defaultFormatter": "daangn-ml-data-platform.expr-lang-support"
     }
   }
   ```

packages/vscode/out/extension.js

@@ -2,7 +2,7 @@
   "name": "expr-lang-support",
   "displayName": "Expr Lang - Syntax & Formatter",
   "description": "Syntax highlighting and formatting for Expr language (.expr files)",
-  "version": "0.3.0",
+  "version": "0.4.0",
   "publisher": "daangn-ml-data-platform",
   "repository": {
     "type": "git",

packages/vscode/out/extension.js.map

@@ -1,4 +1,5 @@
 import * as vscode from 'vscode';
+import * as path from 'path';
 import { format } from './formatter';
 
 // Rainbow bracket colors - optimized for readability
@@ -236,6 +237,101 @@ function updateIndentGuides(editor: vscode.TextEditor | undefined) {
   }
 }
 
+class ExprFileLinkProvider implements vscode.DocumentLinkProvider {
+  provideDocumentLinks(
+    document: vscode.TextDocument
+  ): vscode.DocumentLink[] | undefined {
+    const links: vscode.DocumentLink[] = [];
+    const text = document.getText();
+
+    // Match quoted strings containing .expr files
+    const regex = /["']([^"']+\.expr)["']/g;
+    let match;
+
+    while ((match = regex.exec(text)) !== null) {
+      const filePath = match[1];
+      const startPos = document.positionAt(match.index + 1); // +1 to skip opening quote
+      const endPos = document.positionAt(match.index + 1 + filePath.length);
+      const range = new vscode.Range(startPos, endPos);
+
+      try {
+        // Resolve file path relative to current document
+        const currentDir = path.dirname(document.uri.fsPath);
+        const fullPath = path.resolve(currentDir, filePath);
+        const fileUri = vscode.Uri.file(fullPath);
+
+        // Create document link
+        const link = new vscode.DocumentLink(range, fileUri);
+        link.tooltip = `Open ${filePath}`;
+        links.push(link);
+      } catch (error) {
+        console.error('[ExprLink] Error resolving expr file path:', error);
+      }
+    }
+
+    return links;
+  }
+}
+
+class ExprFileDefinitionProvider implements vscode.DefinitionProvider {
+  provideDefinition(
+    document: vscode.TextDocument,
+    position: vscode.Position
+  ): vscode.ProviderResult<vscode.Definition | vscode.LocationLink[]> {
+    console.log('[ExprDef] provideDefinition called at', position.line, position.character);
+
+    const line = document.lineAt(position.line);
+    const lineText = line.text;
+    console.log('[ExprDef] Line text:', lineText);
+
+    // Scan the entire line for .expr files and find the one under cursor
+    const regex = /["']([^"']+\.expr)["']/g;
+    let match;
+
+    while ((match = regex.exec(lineText)) !== null) {
+      const filePath = match[1];
+      const matchStart = match.index + 1; // +1 to skip opening quote
+      const matchEnd = matchStart + filePath.length;
+
+      console.log('[ExprDef] Checking match:', filePath, 'range:', matchStart, '-', matchEnd);
+
+      // Check if cursor is within this match (including the filename)
+      if (position.character >= matchStart && position.character <= matchEnd) {
+        console.log('[ExprDef] Cursor is within match!');
+
+        try {
+          // Resolve file path relative to current document
+          const currentDir = path.dirname(document.uri.fsPath);
+          const fullPath = path.resolve(currentDir, filePath);
+          const fileUri = vscode.Uri.file(fullPath);
+
+          console.log('[ExprDef] Resolved full path:', fullPath);
+
+          // Create the range for the entire filename (without quotes)
+          const originSelectionRange = new vscode.Range(
+            new vscode.Position(position.line, matchStart),
+            new vscode.Position(position.line, matchEnd)
+          );
+
+          // Return LocationLink with explicit range for better hover UX
+          return [{
+            originSelectionRange: originSelectionRange,
+            targetUri: fileUri,
+            targetRange: new vscode.Range(0, 0, 0, 0),
+            targetSelectionRange: new vscode.Range(0, 0, 0, 0)
+          }];
+        } catch (error) {
+          console.error('[ExprDef] Error resolving expr file path:', error);
+          return undefined;
+        }
+      }
+    }
+
+    console.log('[ExprDef] No match found');
+    return undefined;
+  }
+}
+
 export function activate(context: vscode.ExtensionContext) {
   console.log('Expr language extension activated');
 
@@ -311,12 +407,28 @@ export function activate(context: vscode.ExtensionContext) {
     }
   });
 
+  // Register document link provider for .expr file highlighting
+  // Makes .expr files appear as clickable links in all file types
+  const linkProvider = vscode.languages.registerDocumentLinkProvider(
+    { scheme: 'file' },
+    new ExprFileLinkProvider()
+  );
+
+  // Register definition provider for .expr file navigation
+  // Works in all file types (markdown, plaintext, etc.)
+  const definitionProvider = vscode.languages.registerDefinitionProvider(
+    { scheme: 'file' },
+    new ExprFileDefinitionProvider()
+  );
+
   context.subscriptions.push(
     formatterProvider,
     formatCommand,
     editorChangeListener,
     documentChangeListener,
-    configChangeListener
+    configChangeListener,
+    linkProvider,
+    definitionProvider
   );
 }