Skip to content

feat(lynx): add scale feedback - #2135

Open
junghyeonsu wants to merge 11 commits into
minorfrom
feat/lynx-scale-feedback
Open

feat(lynx): add scale feedback#2135
junghyeonsu wants to merge 11 commits into
minorfrom
feat/lynx-scale-feedback

Conversation

@junghyeonsu

@junghyeonsu junghyeonsu commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

변경 사항

  • Lynx Main Thread에서 Element.animate()로 실행되는 useScaleFeedback을 추가합니다.
  • wrapper 없이 단일 child에 Self Scale을 적용하는 ScaleFeedback utility component를 공개합니다.
  • utility가 child의 기존 Main Thread touch/layout handler와 callback·object ref를 덮어쓰지 않고 합성합니다.
  • trigger와 target을 같은 요소에 적용하는 Self Scale, 서로 다른 요소에 적용하는 Content Scale을 지원합니다.
  • ActionButton, Chip, Callout, Tabs에는 Self Scale을, Accordion, Checkbox, RadioGroup, Switch에는 Content Scale을 적용합니다.
  • Rootage의 pressed-scale duration·easing으로 Main Thread용 runtime primitive를 생성합니다.
  • GlobalProps.motion === "reduced"와 disabled 상태에서는 scale을 적용하지 않으며, 값이 없거나 알 수 없으면 기본 motion으로 fallback합니다.
  • Lynx Scale Feedback 개념 문서와 실행 예제를 추가하고 최소 지원 기준을 Lynx Engine 3.9로 명시합니다.
  • @seed-design/lynx-react, @seed-design/lynx-css minor changeset을 추가합니다.

PR Stack

검증

  • bun generate:all
  • bun --filter @seed-design/lynx-react typecheck
  • bun --filter @seed-design/lynx-react test --run — 247 tests passed
  • bun --filter @seed-design/lynx-react build
  • bun test:all

런타임 기준

  • SEED가 보장하는 최소 버전은 Lynx Engine 3.9입니다.
  • motion이 없는 호스트는 기본 motion을 유지하며, 정확히 "reduced"일 때만 scale을 비활성화합니다.
  • 실제 PlayLynx 및 Karrot Alpha 3.9 host 검증은 seed-design-lynx #2에서 분리해 기록합니다.

참고

  • 이 설계와 문서 초안은 LLM의 도움을 받아 작성하고 사람이 검토했습니다.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 784b31fa-104f-4c97-9057-86c3f7d4dccb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@changeset-bot

changeset-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6f60f1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@seed-design/lynx-react Minor
@seed-design/lynx-css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Alpha Preview (Stackflow SPA)

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Alpha Preview (Storybook)

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Alpha Preview (Docs)

@junghyeonsu
junghyeonsu force-pushed the feat/lynx-scale-feedback branch from 9c05817 to bc91f55 Compare September 1, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant