Fix circular structure error in OpenTelemetry sink - #202
Merged
dahlia merged 1 commit intoAug 21, 2026
Conversation
Scrumplex
marked this pull request as ready for review
August 10, 2026 18:05
Contributor
Author
|
I'll take a look at the type error later today! |
Scrumplex
force-pushed
the
fix/otel/circular-references
branch
from
August 13, 2026 16:12
05610cb to
1a5a6ca
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
- Coverage 86.01% 85.91% -0.10%
==========================================
Files 70 71 +1
Lines 12883 12896 +13
Branches 2904 2910 +6
==========================================
- Hits 11081 11080 -1
- Misses 1276 1285 +9
- Partials 526 531 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Scrumplex
force-pushed
the
fix/otel/circular-references
branch
from
August 15, 2026 12:02
1a5a6ca to
6c119f4
Compare
dahlia
requested changes
Aug 18, 2026
dahlia
left a comment
dahlia
left a comment
Owner
There was a problem hiding this comment.
Thanks for your contribution! Could you address the following issues?
- Since it's a bug fix, could you change the target branch of this pull request to
2.3-maintenance(instead ofmain)? - Please add a changelog fragment (see also the docs of Sacho, the changelog manager we use).
Scrumplex
marked this pull request as draft
August 20, 2026 17:42
Very similar to 8821447. In addition to fixing the inspect call, I also needed to track objects seen in the convertValueToAnyValue recursion as it would otherwise cause an infinite recursion in some cases. Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex
force-pushed
the
fix/otel/circular-references
branch
from
August 20, 2026 17:48
6c119f4 to
065b1f7
Compare
Scrumplex
marked this pull request as ready for review
August 20, 2026 17:48
Owner
|
Shipped with LogTape 2.3.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very similar to 8821447.
In addition to fixing the inspect call, I also needed to track objects
seen in the convertValueToAnyValue recursion as it would otherwise cause
an infinite recursion in some cases.