Repository navigation
Decode weather tool arguments before function feedback - #818
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
|
@dajiaohuang is attempting to deploy a commit to the DAIR-AI Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
pe-function-calling.ipynb, the final tool-feedback example passesfunction.argumentsdirectly intoget_current_weather(location, unit="fahrenheit").Those arguments are JSON text, not a location string. For a supported tool call with
{"location":"Boston","unit":"celsius"}, the tool result instead contains the entire JSON string aslocationand silently usesfahrenheit. The notebook's savedmessagesoutput already shows the nested-JSON location for its Boston example.Change
Decode the arguments and unpack them as keyword arguments, matching the earlier
args = json.loads(...)/get_current_weather(**args)example in this same notebook and the OpenAI cookbook argument-handling contract. Clear the affected downstream outputs/execution counts rather than present stale results as a new model run. No model/API version changes.Validation
Offline fixture executes the notebook's actual dummy weather function and tool-feedback cell, with synthetic assistant/tool-call messages:
git diff --checkpasses.No LLM/API calls, environment-key reads or real weather requests were performed. Full live notebook execution is not claimed.