Localized formatting for season and episode display - #1884
Open
tal-sarid wants to merge 5 commits into
Open
Conversation
damontecres
requested changes
Aug 29, 2026
damontecres
left a comment
damontecres
left a comment
Owner
There was a problem hiding this comment.
This looks pretty good!
Just need to switch from LocalContext to LocalResources in a few places.
Co-authored-by: Damontecres <damontecres@gmail.com>
Contributor
Author
|
I fixed the unit tests by falling back to default format strings when Also, I noticed that I had a missing case for hours+seconds localized duration format and fixed it but if you think it is totally unrelated here I can revert it and open a different PR for that. |
damontecres
approved these changes
Sep 1, 2026
damontecres
left a comment
damontecres
left a comment
Owner
There was a problem hiding this comment.
Looks good to me!
Also, I noticed that I had a missing case for hours+seconds localized duration format and fixed it but if you think it is totally unrelated here I can revert it and open a different PR for that.
It's small and related-ish, so I think it's fine!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added localized formatting for season/episode numbers across the UI because it was in English-only in every UI language.
Related issues
None
Testing
Tested on a physical Google TV Streamer 4K device. Checked manually relevant screens while browsing and during playback.
Screenshots
No frontend changes are visible in English and new translations will be contributed through Weblate for other languages later, as usual.
AI or LLM usage
Generated initial code with AI, then manually passed over it while cleaning and refactoring where needed.