Skip to content

Commit b0dde27

Browse files
authored
Merge pull request #38 from dandwhelan/docs/claude-md-updates
docs: fix stale upstream version, add two testing gotchas to CLAUDE.md
2 parents e1369ab + 5a03c4c commit b0dde27

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎CLAUDE.md‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,10 @@ source setup.csh
4545

4646
The `run_all` script is a thin wrapper; you can run `unit_test.py` directly from the `coverage/` directory (it needs to be the working directory so relative paths resolve).
4747

48+
**Live-instance collision**: `tests/test_web_if.py` posts to a hardcoded `http://127.0.0.1:5052`. On a machine that also runs a live Predbat instance bound to that port (e.g. via Docker), the test's POSTs — including `/restart` and mode changes — land on the live instance instead of the test's own web server. Changing `coverage/apps.yaml`'s `web_port` does not help, since the test's client target is hardcoded separately from the server it starts. Check for anything already bound to port 5052 (`docker ps`, `lsof -i :5052`) before running the full or `--quick` suite anywhere a live instance might be running.
49+
50+
**Known flaky test**: `tests/test_manual_select.py` picks a dropdown option by weekday label (`"%a %H:%M"`) and can fail near midnight UTC, when the label's weekday falls behind the harness's "today" — `get_override_time_from_string` then resolves it into the past and `manual_select` returns `off`. A failure here in that window is not necessarily a regression; rerunning after the boundary passes should confirm.
51+
4852
## Code Quality
4953

5054
All checks are enforced via pre-commit and must pass before merging:
@@ -181,7 +185,7 @@ This fork's kernel binaries are built with ABI/parity revision **103** (upstream
181185

182186
## Fork-Specific Notes
183187

184-
This repository is a personal fork of `springfall2008/batpred` (currently based on upstream v8.46.4). Fork changes on top of upstream:
188+
This repository is a personal fork of `springfall2008/batpred` (currently based on upstream v8.48.1). Fork changes on top of upstream:
185189

186190
- **FIT support** — see the Feed-in Tariff section above
187191
- **Custom web dashboard** — the port-5052 web UI has a `/dash_entities` page and a redesigned power flow diagram (`web.py`, `web_helper.py`)

0 commit comments

Comments
 (0)