Repository navigation
docs: fix stale upstream version, add two testing gotchas to CLAUDE.md - #38
Merged
Merged
Conversation
- Fork-Specific Notes said upstream v8.46.4; main merged v8.48.1 last night (10c4f39) and the note was never updated. - test_web_if.py hardcodes http://127.0.0.1:5052, so on a machine that also runs a live Predbat instance on that port, its POSTs land there instead of the test's own server - which is exactly what happened running the suite on this fork's own Pi tonight. Documented, including that changing coverage/apps.yaml's web_port does not help, since the test's client target is separate from the server it starts. - test_manual_select.py picks a dropdown option by weekday label and can fail near midnight UTC when the label's weekday falls behind the harness's "today" (get_override_time_from_string resolves it into the past). Verified by rerunning the same commit's CI across the boundary: failed three times before 00:00 UTC, passed after. Documented so a hit in that window is not mistaken for a regression. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only, no code changes.
Fix
10c4f397) and the note was never updated.Additions to "Running Tests"
tests/test_web_if.pyposts to a hardcodedhttp://127.0.0.1:5052. On a machine that also runs a live Predbat instance on that port, its POSTs — including/restartand mode changes — land there instead of the test's own server. This is exactly what happened running the suite on this fork's own Pi tonight (see fix(db): treat an unreadable image as proof of corruption #36's discussion). Noted that changingcoverage/apps.yaml'sweb_portdoes not help, since the test's client target is hardcoded separately from the server it starts.tests/test_manual_select.pypicks a dropdown option by weekday label and can fail near midnight UTC, when the label's weekday falls behind the harness's "today". Verified directly tonight: the identical commit on chore: bump THIS_VERSION to v712.19 #37 failed CI three times before 00:00 UTC and passed once past it. Documented so a hit in that window isn't mistaken for a regression.🤖 Generated with Claude Code