Repository navigation
Accept Octopus free-session events with code: null - #54
Merged
Merged
Conversation
…008#4835) fetch_octopus_sessions() required a truthy code for octopus_free_session events, but auto-joined events like Weekend Happy Hours publish code: null - only "available to join" events carry one. Two sibling code paths already gate on start/end alone; this one now matches. code was never used downstream (the resulting slot only carries start/end/rate), so dropping the requirement is safe - kept for the diagnostic log only, falling back to the event id when absent. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> (cherry picked from commit cef15cf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks one fix from upstream v8.54.1 (
cef15cf0, upstream springfall2008#4837 for issue springfall2008#4835). The rest of v8.54.1 is not taken.The bug
fetch_octopus_sessions()required a truthycodebefore it would build a free slot:Auto-joined events — Weekend Happy Hours is the live example — publish
code: null. Only "available to join" events carry a code, so every auto-joined free session was silently dropped and never reached the plan. Two sibling code paths in the same function already gate onstart/endalone; this one now matches them.codewas never used downstream (the slot only carriesstart/end/rate), so dropping the requirement is safe. It is kept for the diagnostic log, falling back to the event id when absent.Tests
tests/test_saving_session.pygainstest_octopus_free_session_null_code, registered asoctopus_free_session_null_code. Run in a throwaway container against this branch:Version bumped to v712.27 so the release ships it.