Require admin review for workflow changes, gate npm OIDC behind a tag-only environment - #1533
Merged
Conversation
…-only environment
orta
enabled auto-merge (squash)
August 24, 2026 07:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figured that someone could edit the workflow to drop the checks, so I've tightened up workflow security
Follow-up to #1532, which merged before these commits landed.
#1532 moved publishing to a tag-triggered workflow, on the reasoning that the tag ruleset is the deploy gate. That reasoning has a hole: npm's trusted publishing grants OIDC credentials based on repo + workflow filename, not on the ref. Anyone with write access (241 people) could push a branch containing an edited
npm_publish.ymlwithon: pushand obtain publish rights.Two fixes:
environment: npm-releaseon the publish job. The environment is already created with a tag-only deployment policy and no branch policies, so a branch can never reach it and therefore never gets credentials. This is the actual fix./.github/workflows/,CODEOWNERSitself, and.release-it.json.mainis already configured withrequire_code_owner_reviews: trueandrequired_approving_review_count: 0, so only PRs touching those paths need an admin approval — normal PRs are unaffected.Needs doing on npmjs.com
The trusted publisher config for
dangerneeds its environment field set tonpm-release. Until then this PR will break publishing, so it should be set at merge time.🤖 Generated with Claude Code