Bump the Docker image to node 22 - #1536
Merged
Merged
Conversation
The action image was still on node:20-slim, but @yao-pkg/pkg (pulled in for the prebuilt macOS binaries) declares node >=22, so yarn install aborted with "Found incompatible module" and the image stopped building. node 22 is the smallest jump that clears the engine check, and it matches what CI already tests against. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
orta
enabled auto-merge (squash)
August 27, 2026 20:57
This was referenced Aug 31, 2026
ekampf
pushed a commit
to Twingate/gateway
that referenced
this pull request
Aug 31, 2026
…" (#472) This reverts commit 774036e. ## Related Tickets & Documents - Issue: ## Changes Revert #467. `14.0.6` breaks Github action. The fix danger/danger-js#1536 was merged so we need to wait for `14.0.7`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Release Danger-JS packageworkflow has been failing to build the action image since the prebuilt-binary changes landed:The Dockerfile was still on
node:20-slim.@yao-pkg/pkgis only a devDependency for the macOS binaries, but the Docker build runs a fullyarn installto getbuild:fast, and yarn treats an engine mismatch as a hard error — so the build dies before it compiles anything.Bumps the base image to
node:22-slim: the smallest jump that clears the engine check, matching the version CI already tests against. Node 20 is EOL anyway.Failing run
🤖 Generated with Claude Code