Update dependencies - #76
Merged
Merged
Conversation
Serilog 4.2.0 to 4.4.0 in both projects, CommunityToolkit.Mvvm 8.4.0 to 8.4.2, Serilog.Sinks.Console 6.0.0 to 6.1.1, Microsoft.NET.Test.Sdk 18.8.1 to 18.9.0, and xunit.runner.visualstudio 3.1.5 to 4.0.0. Everything here is a patch or minor bump except the xunit runner, which is a major and the only one that could break quietly, since a runner that silently discovers nothing still reports success. Verified with the exact command CI runs, --blame-hang and the trx logger included: 372 tests discovered and passed, the Blame collector reports "All tests finished running", and TestResults/test-results.trx is written. Also checked the x64 self-contained single-file publish, because Serilog and the MVVM toolkit ship inside the app rather than only in the test host. Formatting clean.
danielchalmers
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine dependency drift, split out from the Flyleaf 9.0 upgrade (#74) so that PR stayed about one thing.
Serilog(both projects)CommunityToolkit.MvvmSerilog.Sinks.ConsoleMicrosoft.NET.Test.Sdkxunit.runner.visualstudioAll patch or minor except the xunit runner, which is a major and the only one here that can break quietly: a runner that silently discovers nothing still exits zero.
Verified with the exact command CI runs,
--blame-hangand the trx logger included. 372 tests discovered and passed, the Blame collector reportedAll tests finished running, andTestResults/test-results.trxwas written. Same check the last runner bump used.Also ran the x64 self-contained single-file publish, since Serilog and the MVVM toolkit ship inside the app rather than only in the test host.
dotnet format --verify-no-changesclean.