Repository navigation
fix: apply default tags via TextUnmarshaler - #1126
Open
vulragrag-star wants to merge 1 commit into
Open
vulragrag-star wants to merge 1 commit into
vulragrag-star wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1126 +/- ##
==========================================
+ Coverage 93.19% 93.20% +0.01%
==========================================
Files 24 24
Lines 5008 5021 +13
==========================================
+ Hits 4667 4680 +13
Misses 273 273
Partials 68 68 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vulragrag-star
force-pushed
the
fix/680-default-text-unmarshaler
branch
from
October 1, 2026 12:36
758b858 to
e4978cc
Compare
Author
|
Added tests for pointer convertType path and invalid TextUnmarshaler defaults. |
Collaborator
|
Hey @vulragrag-star! I haven't properly reviewed this yet, but please move the tests into an existing test file rather than creating a new one. Thank you! |
Types that implement encoding.TextUnmarshaler are modeled as strings in the schema, but convertType still used reflect.Convert for default tags. That panicked for wrappers such as a duration type with default:"10s". Unmarshal string defaults through TextUnmarshaler for runtime defaults, and keep the schema default in wire string form for OpenAPI. Fixes danielgtaylor#680
Author
|
Moved the TextUnmarshaler default tests into |
vulragrag-star
force-pushed
the
fix/680-default-text-unmarshaler
branch
from
October 2, 2026 00:41
e4978cc to
88bb960
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Types that implement
encoding.TextUnmarshalerare modeled as strings in the schema, butconvertTypestill usedreflect.Convertfordefaulttags. That panicked for wrappers such as a duration type withdefault:"10s"(schema type string, Go type not a string).Changes
TextUnmarshalerinconvertTypefor runtime defaultsjsonTag)convertType,findDefaults, andSchemaFromFieldfor TextUnmarshaler defaultsFixes #680