Repository navigation
fix(negotiation): don't panic on empty q param in SelectQValueFast - #1128
Open
dannyshafer wants to merge 1 commit into
Open
dannyshafer wants to merge 1 commit into
dannyshafer wants to merge 1 commit into
Conversation
An Accept header like "a;,b" left start past end when the parameter after ";" was empty, so the q-value slice became header[4:3] and panicked. Only parse the q-value when the slice is non-empty. Fixes danielgtaylor#1127
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1128 +/- ##
=======================================
Coverage 93.19% 93.19%
=======================================
Files 24 24
Lines 5008 5008
=======================================
Hits 4667 4667
Misses 273 273
Partials 68 68 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SelectQValueFastpanics on anAcceptheader likea;,b(slice bounds out of range [4:3]), which a client can trigger throughhuma.WriteErr.When the parameter after
;is empty, the;branch setsstart = pos+1andend = start, and the,that follows then slicesheader[start+2:end+1]with a start past the end. The q-value is now parsed only when that slice is non-empty; otherwise the entry keeps the default q of 1.0, the same as other unparseable q-values such asa;q=invalid.Fixes #1127
Testing
a;,b,a; ,band the exact input from the issue toTestMalformedFast. They panic onmainand pass with this change.go test -fuzztarget overSelectQValueFastfor 60s (about 1.9M inputs) with no panics.go test ./...passes.Side note, not changed here: the existing
len(header) > end+1guard means the q-value of the last entry in the header is never parsed, soSelectQValueFast("a;q=0.5,b;q=0.3", {"a","b"})returnsbwhileSelectQValuereturnsa. Happy to send a separate PR if you'd like that changed.This PR was prepared with AI assistance (Claude Code).