Step 2 - Convert SelectUsers component - #6
Open
danieltott wants to merge 14 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here we needed to find a way to optimize our
expensiveCalculationOnUsersso that it didn't run every time the component rendered, but it did update when theusersprop changed.The first and most simple way to do that is by using
useMemo:However, we can't produce side effects inside of the
useMemofunction. So, ifexpensiveCalculationOnUsersrelied on afetchfor instance, we would need to turn touseEffectonce again.The version of
SelectUsersthat is in this branch reflects this reality: we combineuseStateanduseEffectto manage our expensive calculation, and by addingusersto theuseEffectdependency array, ensure that our component is always synced with theusersprop.