Keep the ISO E2E tests from changing installer logic

Restore every installer, preseed and ISO-generation file to master so
this PR only adds tests. The harness now reproduces real hardware
instead of patching the installer around QEMU:

- Install onto an NVMe disk rather than virtio-blk.
- Boot the guest on a TAP network with DHCP, DNS and NAT. GitHub
  runners drop outbound ICMP, so the host answers the guest's echo
  requests and the first-boot `ping google.com` check behaves as on a
  normal LAN.
- Read the expected Debian release from the generator and preseed
  instead of a new config file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: Marketen

.github/workflows/debian-iso-e2e.yml

@@ -23,9 +23,6 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v6
 
-      - name: Verify Debian release alignment
-        run: bash iso/scripts/check_debian_release_alignment.sh
-
       - name: Build Debian unattended ISO
         run: |
           export BASE_OS=debian
@@ -36,18 +33,21 @@ jobs:
       - name: Install QEMU test dependencies
         run: |
           sudo apt-get update
-          sudo apt-get install -y --no-install-recommends qemu-system-x86 qemu-utils ovmf socat sshpass
+          sudo apt-get install -y --no-install-recommends qemu-system-x86 qemu-utils ovmf socat sshpass dnsmasq-base
           if [ -e /dev/kvm ]; then
             sudo chmod a+rw /dev/kvm
           fi
 
-      - name: Enable ICMP for QEMU user networking
-        run: sudo sysctl -w net.ipv4.ping_group_range="0 2147483647"
+      - name: Create the guest network
+        run: |
+          mkdir -p test-output/debian-e2e
+          sudo E2E_NETWORK_STATE_DIR="${PWD}/test-output/debian-e2e/network" bash test/e2e_network.sh up
 
       - name: Complete Debian unattended UEFI USB installation
         env:
           E2E_BOOT_MODE: usb
           E2E_FIRMWARE: uefi
+          E2E_TAP_IFACE: dne2e0
         run: |
           debian_iso=$(find images -maxdepth 1 -type f -name 'Dappnode-debian-*-amd64-netinst.iso' -print -quit)
           test -n "${debian_iso}"

.github/workflows/ubuntu-iso-e2e.yml

@@ -33,18 +33,21 @@ jobs:
       - name: Install QEMU test dependencies
         run: |
           sudo apt-get update
-          sudo apt-get install -y --no-install-recommends qemu-system-x86 qemu-utils ovmf socat sshpass
+          sudo apt-get install -y --no-install-recommends qemu-system-x86 qemu-utils ovmf socat sshpass dnsmasq-base
           if [ -e /dev/kvm ]; then
             sudo chmod a+rw /dev/kvm
           fi
 
-      - name: Enable ICMP for QEMU user networking
-        run: sudo sysctl -w net.ipv4.ping_group_range="0 2147483647"
+      - name: Create the guest network
+        run: |
+          mkdir -p test-output/ubuntu-e2e
+          sudo E2E_NETWORK_STATE_DIR="${PWD}/test-output/ubuntu-e2e/network" bash test/e2e_network.sh up
 
       - name: Complete Ubuntu unattended UEFI USB installation
         env:
           E2E_BOOT_MODE: usb
           E2E_FIRMWARE: uefi
+          E2E_TAP_IFACE: dne2e0
         run: |
           ubuntu_iso=$(find images -maxdepth 1 -type f -name 'Dappnode-ubuntu-*-live-server-amd64.iso' -print -quit)
           test -n "${ubuntu_iso}"

iso/debian_release.conf

@@ -25,7 +25,7 @@ d-i mirror/country string manual
 d-i mirror/http/hostname string deb.debian.org
 d-i mirror/http/directory string /debian
 d-i mirror/http/proxy string
-d-i apt-setup/local0/repository string http://deb.debian.org/debian/ @DEBIAN_SUITE@ main contrib non-free-firmware
+d-i apt-setup/local0/repository string http://deb.debian.org/debian/ trixie main contrib non-free-firmware
 d-i apt-setup/cdrom/set-first boolean false
 d-i apt-setup/cdrom/set-next boolean false   
 d-i apt-setup/cdrom/set-failed boolean false

iso/preseeds/preseed.cfg

@@ -62,7 +62,7 @@ d-i mirror/country string manual
 d-i mirror/http/hostname string deb.debian.org
 d-i mirror/http/directory string /debian
 d-i mirror/http/proxy string
-d-i apt-setup/local0/repository string http://deb.debian.org/debian/ @DEBIAN_SUITE@ main contrib non-free-firmware
+d-i apt-setup/local0/repository string http://deb.debian.org/debian/ trixie main contrib non-free-firmware
 d-i apt-setup/cdrom/set-first boolean false
 d-i apt-setup/cdrom/set-next boolean false
 d-i apt-setup/cdrom/set-failed boolean false

iso/preseeds/preseed_unattended.cfg

@@ -4,32 +4,16 @@ WORKDIR="/usr/src/app"
 ISO_BUILD_PATH="${WORKDIR}/dappnode-iso"
 DAPPNODE_ISO_PREFIX="Dappnode-"
 
-# Usage: download_iso <path> <name> <url> [fallback_url...]
-# URLs are tried in order, which covers mirrors that move older releases elsewhere.
 download_iso() {
     local iso_path=$1
     local iso_name=$2
-    shift 2
+    local iso_url=$3
 
     echo "[INFO] Downloading base ISO image: ${iso_name}..."
-    if [ -f "${iso_path}" ]; then
-        echo "[INFO] Download complete!"
-        return 0
+    if [ ! -f "${iso_path}" ]; then
+        wget "${iso_url}" -O "${iso_path}"
     fi
-
-    local iso_url
-    for iso_url in "$@"; do
-        if wget "${iso_url}" -O "${iso_path}"; then
-            echo "[INFO] Download complete!"
-            return 0
-        fi
-        # wget leaves a partial file behind, which would be reused on the next run
-        rm -f "${iso_path}"
-        echo "[WARN] Could not download ${iso_url}"
-    done
-
-    echo "[ERROR] Could not download ${iso_name} from any known location"
-    exit 1
+    echo "[INFO] Download complete!"
 }
 
 verify_download() {

iso/scripts/check_debian_release_alignment.sh

@@ -4,24 +4,17 @@ set -e
 SCRIPTS_DIR=$(dirname "${BASH_SOURCE[0]}")
 
 source ${SCRIPTS_DIR}/common_iso_generation.sh
-source ${SCRIPTS_DIR}/../debian_release.conf
 
 BASE_ISO_NAME="debian-13.5.0-amd64-netinst.iso"
 BASE_ISO_VERSION="${BASE_ISO_NAME#debian-}"
 BASE_ISO_VERSION="${BASE_ISO_VERSION%-amd64-netinst.iso}"
 BASE_ISO_PATH="/images/${BASE_ISO_NAME}"
-# Debian serves the newest point release from debian-cd/ and only moves it to the
-# archive once it is superseded, so try both.
-BASE_ISO_URL="https://cdimage.debian.org/debian-cd/${BASE_ISO_VERSION}/amd64/iso-cd/${BASE_ISO_NAME}"
-BASE_ISO_ARCHIVE_URL="https://cdimage.debian.org/mirror/cdimage/archive/${BASE_ISO_VERSION}/amd64/iso-cd/${BASE_ISO_NAME}"
+BASE_ISO_URL="https://cdimage.debian.org/mirror/cdimage/archive/${BASE_ISO_VERSION}/amd64/iso-cd/${BASE_ISO_NAME}"
 BASE_ISO_SHASUM="95838884f5ea6c82421dfe6baaa5a639dbbe6756c1e380f9fe7a7cb0c1949d2a  ${BASE_ISO_PATH}"
 
 DAPPNODE_ISO_NAME="${DAPPNODE_ISO_PREFIX}${BASE_ISO_NAME}"
 DAPPNODE_ISO_PATH="/images/${DAPPNODE_ISO_NAME}"
 
-# Fail before downloading or building if the ISO and repositories target different releases.
-bash "${SCRIPTS_DIR}/check_debian_release_alignment.sh"
-
 customize_debian_preseed() {
     local iso_build_path=$1
     local workdir=$2
@@ -57,13 +50,6 @@ customize_debian_preseed() {
         exit 1
     }
 
-    # Keep package repositories aligned with the Debian release used by the ISO.
-    sed -i "s/@DEBIAN_SUITE@/${DEBIAN_SUITE}/g" "${tmp_initrd}/preseed.cfg"
-    if grep -q "@DEBIAN_SUITE@" "${tmp_initrd}/preseed.cfg"; then
-        echo "[ERROR] Could not render the Debian suite in the preseed file"
-        exit 1
-    fi
-
     # Recreate (and recompress) the initrd
     (cd "${tmp_initrd}" && find . -print0 | cpio -0 -ov -H newc | gzip >"${install_dir}/initrd.gz") || {
         echo "[ERROR] Could not create new initrd"
@@ -101,7 +87,7 @@ generate_debian_iso() {
         -isohybrid-gpt-basdat -o "${iso_output_path}" ${iso_build_path}
 }
 
-download_iso "${BASE_ISO_PATH}" "${BASE_ISO_NAME}" "${BASE_ISO_URL}" "${BASE_ISO_ARCHIVE_URL}"
+download_iso "${BASE_ISO_PATH}" "${BASE_ISO_NAME}" "${BASE_ISO_URL}"
 verify_download "${BASE_ISO_PATH}" "${BASE_ISO_SHASUM}"
 clean_old_files "${ISO_BUILD_PATH}" "${DAPPNODE_ISO_PREFIX}"
 extract_iso "${BASE_ISO_PATH}" "${ISO_BUILD_PATH}"

iso/scripts/common_iso_generation.sh

@@ -12,14 +12,4 @@ for DISK in ${DEVICE}; do
     DISKS="${DISKS} ${DISK}";
 done;
 DISKS=$(echo "${DISKS}" | sed "s/^ //g");
-debconf-set partman-auto/disk "$DISKS";
-
-# grub-installer/bootdev is preseeded to "default", which marks the question as
-# already seen. grub-installer then resolves "default" to the first entry of
-# grub-mkdevicemap, i.e. (hd0) -- the installer USB itself. Its safeguard against
-# installing onto the installation media only runs for grub-pc, so on UEFI it
-# happily targets the stick and then dies reading its partition table:
-#   Can't read partition table from /dev/sda
-# Point it at the same non-USB disks partman is using. grub-installer accepts a
-# space separated list and installs to each entry in turn.
-debconf-set grub-installer/bootdev "$DISKS";
+debconf-set partman-auto/disk "$DISKS"; 

iso/scripts/generate_dappnode_iso_debian.sh

@@ -428,16 +428,7 @@ normalize_ipfs_version_ref() {
         local cid_path="$ref"
         local manifest_url="${IPFS_ENDPOINT%/}${cid_path}/dappnode_package.json"
         local manifest
-        local attempt
-        for attempt in 1 2 3 4 5; do
-            manifest="$(download_stdout "$manifest_url" 2>/dev/null || true)"
-            if [[ -n "$manifest" ]]; then
-                break
-            fi
-            if [[ "$attempt" -lt 5 ]]; then
-                sleep 2
-            fi
-        done
+        manifest="$(download_stdout "$manifest_url" 2>/dev/null || true)"
         if [[ -z "$manifest" ]]; then
             error "Could not fetch IPFS manifest for ${comp} from: $manifest_url"
             error "Provide ${comp}_VERSION as /ipfs/<cid>:<version> (example: /ipfs/Qm...:0.2.11)"