Repository navigation
fix: use boolean notification flags (SPEC-F03) - #206
Merged
Merged
Conversation
Contributor
|
Dappnode bot has built and pinned the built packages to an IPFS node, for commit: 5e85cb7 This is a development version and should only be installed for testing purposes.
Hash: (by dappnodebot/build-action) |
Contributor
✅ Package harness passed
Run overview
Baseline vs candidate
Container comparison
Container inventoryBaseline
Candidate
Runtime analysis advisory⚪ Inconclusive — Heuristic and Nexus analysis: No likely new runtime regression is visible in the candidate cAdvisor logs, whose startup behavior matches the baseline. A candidate-wide comparison is not possible because the supplied candidate evidence is truncated after cAdvisor and does not expose the other containers.
✅ No new runtime findings were reported. Cleanup and diagnostics
✅ No run errors were recorded. Deterministic checks decide the verdict. Runtime log analysis is advisory. TropiBot publishes bounded summaries and never posts raw logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Correct SPEC-F03 from the package specification checks.
Stacked on #205 (base
fix/spec-m08-repository-url). Merge the base PR first; this diff contains only the next focused fix.Approach
Write all four isBanner flags as booleans so the notification source already matches the validated release object.
Test instructions
Run the SDK package-spec validation on this branch for all package variants.
Verified locally:
docker compose config --quietpass for every variant.git diff --checkand replay of the complete PR stack pass.isBannerflags already typed as booleans.Full container images were not built locally.