Skip to content

fix: remove fixed service container names (SPEC-C02) - #65

Merged
3alpha merged 1 commit into
fix/spec-m03-upstream-metadatafrom
fix/spec-c02-container-names
Nov 9, 2026
Merged

3alpha merged 1 commit into
fix/spec-m03-upstream-metadatafrom
fix/spec-c02-container-names

Conversation

@3alpha

@3alpha 3alpha commented Nov 9, 2026

Copy link
Copy Markdown
Member

Context

Correct SPEC-C02 from the package specification checks.

Stacked on #64 (base fix/spec-m03-upstream-metadata). Merge the base PR first; this diff contains only the next focused fix.

Approach

Remove fixed container names from package services; DAPPMANAGER supplies those names at installation. Keep the service definitions, ports and volumes unchanged.

Test instructions

Run the SDK package-spec validation on this branch for all package variants.

Verified locally:

  • SDK loading and manifest/optional-asset schemas pass for all 1 variant.
  • Release-file generation, avatar verification and docker compose config --quiet pass for every variant.
  • Compared effective service settings, image/version pins and package identities with the parent: preserved.
  • git diff --check and replay of the complete PR stack pass.
  • SPEC-C02 findings in this layer: 1 → 0.

Full container images were not built locally.

@tropibot

tropibot Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Dappnode bot has built and pinned the built packages to an IPFS node, for commit: b690a6d

This is a development version and should only be installed for testing purposes.

  1. Package hermes-agent.dnp.dappnode.eth

Install link

Hash: /ipfs/QmSktqSEaSRwnuimEPtrfyf7jZtPvMtFYtDMDMxbwrgbJ3

(by dappnodebot/build-action)

@3alpha
3alpha added this pull request to stack #66 November 9, 2026 12:08
@3alpha
3alpha merged commit 6f3a424 into main Nov 9, 2026
5 checks passed
@3alpha
3alpha deleted the fix/spec-c02-container-names branch November 9, 2026 12:11
@tropibot

tropibot Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

✅ Package harness passed

Baseline and candidate containers became stably running

Package Verdict Reason Duration Cleanup
hermes-agent.dnp.dappnode.eth ✅ Passed Candidate containers stable (candidate_containers_stable) 10m 35s ✅ Passed

Run overview

Context Value
Pull request dappnode/DAppNodePackage-Hermes-agent#65
Tested commit b690a6dd857e
Candidate artifact Install on DAppNode · /ipfs/QmSktqSEaSRwnuimEPtrfyf7jZtPvMtFYtDMDMxbwrgbJ3
Baseline request automatic
Worker dappnode-near-5
Run ID gh-pr-65-b690a6dd857e-455ec16eb90ef4c7
Execution 2026-11-09T12:40:58.898056166+00:00 → 2026-11-09T12:51:34.349295859+00:00 (✅ Completed)

Baseline vs candidate

Check Baseline Candidate
Version 0.1.9 0.1.9
Install ✅ Passed · 0s ✅ Passed · 8m 49s
Hard check ✅ Passed · 3 stable samples ✅ Passed · 3 stable samples
Containers 1 observed 1 observed
Stabilization 10s 10s
Log collection ✅ Passed · 1 container ✅ Passed · 1 container

Container comparison

  • Added: none
  • Removed: none
  • Baseline inventory: DAppNodePackage-hermes-agent.hermes-agent.dnp.dappnode.eth
  • Candidate inventory: DAppNodePackage-hermes-agent.hermes-agent.dnp.dappnode.eth
  • Baseline non-running states: none
  • Candidate non-running states: none
  • Deterministic regressions: ✅ none
Container inventory

Baseline

Container Service State Image Created
DAppNodePackage-hermes-agent.hermes-agent.dnp.dappnode.eth hermes-agent ✅ Running hermes-agent.hermes-agent.dnp.dappnode.eth:0.1.9 1794224975

Candidate

Container Service State Image Created
DAppNodePackage-hermes-agent.hermes-agent.dnp.dappnode.eth hermes-agent ✅ Running hermes-agent.hermes-agent.dnp.dappnode.eth:0.1.9 1794228600

Runtime analysis advisory

✅ Clean — Heuristic and Nexus analysis: Candidate runtime behavior matches the baseline. All initialization and supervised services start successfully, the gateway and dashboard become ready, and no new errors or warning signatures appear.

Analyzer Status Summary
Composite ✅ Clean Heuristic and Nexus analysis: Candidate runtime behavior matches the baseline. All initialization and supervised services start successfully, the gateway and dashboard become ready, and no new errors or warning signatures appear.
Heuristic ✅ Clean No configured candidate-only suspicious signature was found
Nexus ✅ Clean Candidate runtime behavior matches the baseline. All initialization and supervised services start successfully, the gateway and dashboard become ready, and no new errors or warning signatures appear.
Baseline evidence ✅ Clean No configured suspicious signature was found
Candidate evidence ✅ Clean No configured suspicious signature was found

✅ No new runtime findings were reported.

Cleanup and diagnostics

Check Result
Cleanup ✅ Passed
Leftover packages none
Cleanup error none

✅ No run errors were recorded.


Deterministic checks decide the verdict. Runtime log analysis is advisory. TropiBot publishes bounded summaries and never posts raw logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant