Repository navigation
fix: secure Honcho wizard with a Dappnode-configured password - #7
Open
sembrestels wants to merge 1 commit into
Open
sembrestels wants to merge 1 commit into
sembrestels wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The setup wizard currently allows unauthenticated callers to read saved provider keys and overwrite configuration. The API and deriver source that configuration as shell code, so unrestricted writes also create an injection path.
Require a wizard password chosen through Dappnode's installation form or package Config. Users unlock the existing internal wizard URL with that password; SSH credential retrieval is not required.
Changes
HONCHO_WIZARD_PASSWORDsetup field supplied only tosetup-wizard. Missing or invalid passwords fail startup with Config instructions; there is no default password or first-visitor registration.apialias.Upgrade and recovery
For existing installations, set
HONCHO_WIZARD_PASSWORDforsetup-wizardin Honcho's Config and restart that service. Change or recover the password through the same Dappnode UI. Provider keys are preserved. Earlier development-build SSH tokens are no longer accepted.Validation and scope