Skip to content

fix: remove stale root metrics targets (SPEC-T04) - #99

Merged
3alpha merged 1 commit into
mainfrom
fix/spec-t04-metrics-targets
Nov 9, 2026
Merged

3alpha merged 1 commit into
mainfrom
fix/spec-t04-metrics-targets

Conversation

@3alpha

@3alpha 3alpha commented Nov 9, 2026

Copy link
Copy Markdown
Member

Context

Correct SPEC-T04 from the package specification checks.

Based on the default branch main.

Approach

Remove the stale shared Prometheus targets file. Every variant already provides the targets that override it in releases.

Test instructions

Run the SDK package-spec validation on this branch for all package variants.

Verified locally:

  • SDK loading and manifest/optional-asset schemas pass for all 3 variants.
  • Release-file generation, avatar verification and docker compose config --quiet pass for every variant.
  • Compared effective service settings, image/version pins and package identities with the parent: preserved.
  • git diff --check and replay of the complete PR stack pass.
  • SPEC-T04 findings in this layer: 3 → 0.

Full container images were not built locally.

@3alpha
3alpha merged commit ce65a28 into main Nov 9, 2026
4 checks passed
@tropibot

tropibot Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

✅ TropiBot report: SYNC TEST REPORT - PASSED

This CI runs on a real DAppNode using the same RPC calls a user would make to configure a staker setup: execution client, consensus client, web3signer, MEV-boost, and relays.

📦 Package Under Test

📦 Clients Used

Component DNP Name
Execution hoodi-erigon.dnp.dappnode.eth
Consensus nimbus-hoodi.dnp.dappnode.eth
Web3Signer web3signer-hoodi.dnp.dappnode.eth
MEV Boost mev-boost-hoodi.dnp.dappnode.eth
Network hoodi

🔖 Version Tracking

Client Before After
Execution erigon/3.8.1-cf6f1413/linux-amd64/go1.27.3 erigon/3.8.1-cf6f1413/linux-amd64/go1.27.3
Consensus n/a Nimbus/v26.10.2-0abc0d-stateofus

⏱️ Timing

Operation Duration Status
SetStakerConfig 59.9s ✅
PackageInstall 31.6s ✅
WaitForSync 1m 13s ✅
Cleanup 15.7s ✅

Total Duration: 3m 16s


📋 View full CI logs

@3alpha
3alpha deleted the fix/spec-t04-metrics-targets branch November 9, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant