Skip to content

fix: keep package identities in variants (SPEC-T01) - #36

Merged
3alpha merged 1 commit into
fix/spec-m03-upstream-metadatafrom
fix/spec-t01-variant-identities
Nov 9, 2026
Merged

3alpha merged 1 commit into
fix/spec-m03-upstream-metadatafrom
fix/spec-t01-variant-identities

Conversation

@3alpha

@3alpha 3alpha commented Nov 9, 2026

Copy link
Copy Markdown
Member

Context

Correct SPEC-T01 from the package specification checks.

Stacked on #35 (base fix/spec-m03-upstream-metadata). Merge the base PR first; this diff contains only the next focused fix.

Approach

Keep package identities in the variant manifests and remove the phantom root identity. Preserve every effective variant name and version.

Test instructions

Run the SDK package-spec validation on this branch for all package variants.

Verified locally:

  • SDK loading and manifest/optional-asset schemas pass for all 2 variants.
  • Release-file generation, avatar verification and docker compose config --quiet pass for every variant.
  • Compared effective service settings, image/version pins and package identities with the parent: preserved.
  • git diff --check and replay of the complete PR stack pass.
  • SPEC-T01 findings in this layer: 1 → 0.

Full container images were not built locally.

@tropibot

tropibot Bot commented Nov 9, 2026

Copy link
Copy Markdown

Dappnode bot has built and pinned the built packages to an IPFS node, for commit: c939b0a

This is a development version and should only be installed for testing purposes.

  1. Package juno-sepolia.dnp.dappnode.eth

Install link

Hash: /ipfs/QmeiALzyMAz9LJG1xB4S1Jrrb4Y39g4zGEejQJ61oSFojb

(by dappnodebot/build-action)

@3alpha
3alpha added this pull request to stack #37 November 9, 2026 12:13
@3alpha
3alpha merged commit 0498224 into main Nov 9, 2026
2 checks passed
@3alpha
3alpha deleted the fix/spec-t01-variant-identities branch November 9, 2026 12:15
@tropibot

tropibot Bot commented Nov 9, 2026

Copy link
Copy Markdown

✅ Package harness passed

Baseline and candidate containers became stably running

Package Verdict Reason Duration Cleanup
juno-sepolia.dnp.dappnode.eth ✅ Passed Candidate containers stable (candidate_containers_stable) 4m 54s ✅ Passed

Run overview

Context Value
Pull request dappnode/DAppNodePackage-juno-generic#36
Tested commit c939b0a04479
Candidate artifact Install on DAppNode · /ipfs/QmeiALzyMAz9LJG1xB4S1Jrrb4Y39g4zGEejQJ61oSFojb
Baseline request automatic
Worker dappnode-near-5
Run ID gh-pr-36-c939b0a04479-cb504fd378002067
Execution 2026-11-09T12:33:31.067598042+00:00 → 2026-11-09T12:38:25.855463518+00:00 (✅ Completed)

Baseline vs candidate

Check Baseline Candidate
Version 0.1.6 0.1.6
Install ✅ Passed · 20s ✅ Passed · 3m 48s
Hard check ✅ Passed · 3 stable samples ✅ Passed · 3 stable samples
Containers 1 observed 1 observed
Stabilization 10s 10s
Log collection ✅ Passed · 1 container ✅ Passed · 1 container

Container comparison

  • Added: none
  • Removed: none
  • Baseline inventory: DAppNodePackage-juno.juno-sepolia.dnp.dappnode.eth
  • Candidate inventory: DAppNodePackage-juno.juno-sepolia.dnp.dappnode.eth
  • Baseline non-running states: none
  • Candidate non-running states: none
  • Deterministic regressions: ✅ none
Container inventory

Baseline

Container Service State Image Created
DAppNodePackage-juno.juno-sepolia.dnp.dappnode.eth juno ✅ Running juno.juno-sepolia.dnp.dappnode.eth:0.1.6 1794227633

Candidate

Container Service State Image Created
DAppNodePackage-juno.juno-sepolia.dnp.dappnode.eth juno ✅ Running juno.juno-sepolia.dnp.dappnode.eth:0.1.6 1794227863

Runtime analysis advisory

✅ Clean — Heuristic and Nexus analysis: No likely new runtime regressions were identified. Baseline and candidate logs show the same Juno startup path and successful snapshot download, with no new errors or warnings.

Analyzer Status Summary
Composite ✅ Clean Heuristic and Nexus analysis: No likely new runtime regressions were identified. Baseline and candidate logs show the same Juno startup path and successful snapshot download, with no new errors or warnings.
Heuristic ✅ Clean No configured candidate-only suspicious signature was found
Nexus ✅ Clean No likely new runtime regressions were identified. Baseline and candidate logs show the same Juno startup path and successful snapshot download, with no new errors or warnings.
Baseline evidence ✅ Clean No configured suspicious signature was found
Candidate evidence ✅ Clean No configured suspicious signature was found

✅ No new runtime findings were reported.

Cleanup and diagnostics

Check Result
Cleanup ✅ Passed
Leftover packages none
Cleanup error none

✅ No run errors were recorded.


Deterministic checks decide the verdict. Runtime log analysis is advisory. TropiBot publishes bounded summaries and never posts raw logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant